From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [patch] ASoC: adau1701: signedness bug in adau1701_write() Date: Mon, 20 Jun 2011 15:03:19 +0100 Message-ID: <4DFF5327.40903@ti.com> References: <20110620071125.GG14591@shale.localdomain> <4DFF1AD6.4090103@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by alsa0.perex.cz (Postfix) with ESMTP id CA988244A0 for ; Mon, 20 Jun 2011 16:03:23 +0200 (CEST) In-Reply-To: <4DFF1AD6.4090103@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: "open list:SOUND - SOC LAYER..." , Dan Carpenter , Takashi Iwai , Mark Brown , "kernel-janitors@vger.kernel.org" List-Id: alsa-devel@alsa-project.org On 20/06/11 11:03, Lars-Peter Clausen wrote: > On 06/20/2011 09:11 AM, Dan Carpenter wrote: >> "ret" is supposed to be signed here. The current code will only >> return -EIO on error, instead of a more appropriate error code such >> as -EAGAIN etc. >> >> Signed-off-by: Dan Carpenter > Acked-by: Lars-Peter Clausen > Acked-by: Liam Girdwood