From: Julian Sikorski <belegdol@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: model needed for Clevo P150HM (Realtek ALC892)
Date: Thu, 23 Jun 2011 18:40:47 +0200 [thread overview]
Message-ID: <4E036C8F.3080709@gmail.com> (raw)
In-Reply-To: <s5h39j0zpnc.wl%tiwai@suse.de>
On 23/06/2011 14:41, Takashi Iwai wrote:
> At Thu, 23 Jun 2011 08:36:55 +0200,
> Julian Sikorski wrote:
>>
>> Hi,
>>
>> I am coming here from pulseaudio-general mailing list [1]. I recently
>> got myself a Clevo P150HM laptop. It has 2.1 speakers, a built-in
>> microphone and the following connectors:
>> - headphone out
>> - microphone in; can be switched to center/lfe out
>> - spdif out; can be switched to rear speaker out
>> - line in; can be switched to side speaker out
>> Alsa does not seem to reflect that the device is capable of 5.1 and 7.1
>> sound, and there are two configs showing up in pavucontrol (analog
>> output and analog headphones) which seem to be the same. I have uploaded
>> the output of alsa-info.sh [2]. Please let me know if more information
>> is needed.
>
> The current parser doesn't allow the multi-io pins when the primary
> output is no line-out. The patch below should fix (change) the
> behavior. It'll count HP out, too.
>
>
> Takashi
>
> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index fe56b2b..b0cf726 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -18992,6 +18992,7 @@ static int alc662_auto_fill_dac_nids(struct hda_codec *codec,
> hda_nid_t dac;
>
> spec->multiout.dac_nids = spec->private_dac_nids;
> + spec->multiout.num_dacs = 0;
> for (i = 0; i< cfg->line_outs; i++) {
> dac = alc_auto_look_for_dac(codec, cfg->line_out_pins[i]);
> if (!dac)
> @@ -19326,8 +19327,20 @@ static int alc_auto_add_multi_channel_mode(struct hda_codec *codec)
> unsigned int location, defcfg;
> int num_pins;
>
> + if (cfg->line_out_type == AUTO_PIN_SPEAKER_OUT&& cfg->hp_outs == 1) {
> + /* use HP as primary out */
> + cfg->speaker_outs = cfg->line_outs;
> + memcpy(cfg->speaker_pins, cfg->line_out_pins,
> + sizeof(cfg->speaker_pins));
> + cfg->line_outs = cfg->hp_outs;
> + memcpy(cfg->line_out_pins, cfg->hp_pins, sizeof(cfg->hp_pins));
> + cfg->hp_outs = 0;
> + memset(cfg->hp_pins, 0, sizeof(cfg->hp_pins));
> + cfg->line_out_type = AUTO_PIN_HP_OUT;
> + alc662_auto_fill_dac_nids(codec, cfg);
> + }
> if (cfg->line_outs != 1 ||
> - cfg->line_out_type != AUTO_PIN_LINE_OUT)
> + cfg->line_out_type == AUTO_PIN_SPEAKER_OUT)
> return 0;
>
> defcfg = snd_hda_codec_get_pincfg(codec, cfg->line_out_pins[0]);
> @@ -19348,6 +19361,8 @@ static int alc_auto_add_multi_channel_mode(struct hda_codec *codec)
> spec->multi_ios = num_pins;
> spec->ext_channel_count = 2;
> spec->multiout.num_dacs = num_pins + 1;
> + /* for avoiding multi HP mixers */
> + cfg->line_out_type = AUTO_PIN_LINE_OUT;
> }
> return 0;
> }
Would you like me to test this patch? If so, what should I apply it to
and how should I proceed?
Julian
next prev parent reply other threads:[~2011-06-23 16:40 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 6:36 model needed for Clevo P150HM (Realtek ALC892) Julian Sikorski
2011-06-23 12:41 ` Takashi Iwai
2011-06-23 16:40 ` Julian Sikorski [this message]
2011-06-24 8:34 ` Takashi Iwai
2011-06-24 9:12 ` Takashi Iwai
2011-06-24 11:25 ` Julian Sikorski
2011-06-25 7:11 ` Takashi Iwai
2011-06-25 9:22 ` Julian Sikorski
2011-06-25 11:08 ` Julian Sikorski
2011-06-25 11:31 ` Julian Sikorski
2011-06-25 12:01 ` Julian Sikorski
2011-06-27 6:04 ` Takashi Iwai
2011-06-27 6:21 ` Julian Sikorski
2011-06-27 9:19 ` Takashi Iwai
2011-06-27 12:32 ` Takashi Iwai
2011-06-27 12:42 ` Julian Sikorski
2011-06-27 12:46 ` Takashi Iwai
2011-06-27 12:55 ` Julian Sikorski
2011-06-27 16:12 ` Takashi Iwai
2011-06-27 20:08 ` Julian Sikorski
2011-06-28 7:12 ` Takashi Iwai
2011-06-28 8:03 ` Julian Sikorski
2011-06-28 9:05 ` Takashi Iwai
2011-06-28 10:36 ` Julian Sikorski
2011-06-28 12:40 ` Takashi Iwai
2011-06-29 17:36 ` Julian Sikorski
2011-06-29 18:16 ` Julian Sikorski
2011-06-29 19:29 ` Julian Sikorski
2011-06-30 5:26 ` Takashi Iwai
2011-06-30 6:33 ` Julian Sikorski
[not found] ` <4E0C17F2.5070704@gmail.com>
2011-06-30 6:54 ` Takashi Iwai
2011-06-30 17:00 ` Julian Sikorski
2011-06-30 17:41 ` Takashi Iwai
2011-06-30 18:09 ` Julian Sikorski
2011-06-30 19:28 ` Takashi Iwai
2011-06-30 20:16 ` Julian Sikorski
2011-07-01 5:21 ` Takashi Iwai
2011-07-01 6:14 ` Julian Sikorski
2011-07-01 6:24 ` Takashi Iwai
2011-07-01 6:27 ` Julian Sikorski
2011-07-01 7:07 ` Julian Sikorski
2011-07-01 7:14 ` Takashi Iwai
2011-07-01 11:18 ` Julian Sikorski
2011-07-01 22:09 ` Julian Sikorski
2011-07-01 22:37 ` Julian Sikorski
2011-07-04 20:47 ` Julian Sikorski
2011-07-05 8:16 ` Julian Sikorski
2011-07-01 7:32 ` Takashi Iwai
2011-07-01 18:57 ` Julian Sikorski
2011-07-01 19:25 ` Takashi Iwai
2011-07-01 19:35 ` Julian Sikorski
2011-07-03 11:22 ` Julian Sikorski
2011-07-04 22:50 ` Julian Sikorski
2011-07-05 1:31 ` Raymond Yau
2011-07-05 7:45 ` Julian Sikorski
2011-07-17 11:55 ` Julian Sikorski
2011-07-17 12:17 ` Julian Sikorski
2011-07-18 7:35 ` Takashi Iwai
2011-07-18 8:52 ` Takashi Iwai
2011-07-18 11:15 ` Julian Sikorski
2011-07-18 11:18 ` Julian Sikorski
2011-07-18 11:19 ` Takashi Iwai
2011-07-18 11:42 ` Julian Sikorski
2011-07-18 12:16 ` Takashi Iwai
2011-07-18 12:42 ` Julian Sikorski
2011-07-18 13:23 ` Takashi Iwai
2011-07-18 13:36 ` Julian Sikorski
2011-07-05 5:32 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2011-06-23 6:40 Julian Sikorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E036C8F.3080709@gmail.com \
--to=belegdol@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox