From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: Ensure we delay long enough for WM8994 FLL to lock when starting
Date: Mon, 4 Jul 2011 10:44:44 +0100 [thread overview]
Message-ID: <4E118B8C.5020600@ti.com> (raw)
In-Reply-To: <1309566922-3177-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 02/07/11 01:35, Mark Brown wrote:
> This delay is very conservative.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8994.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
> index 38abdff..2eb4594 100644
> --- a/sound/soc/codecs/wm8994.c
> +++ b/sound/soc/codecs/wm8994.c
> @@ -1725,6 +1725,8 @@ static int _wm8994_set_fll(struct snd_soc_codec *codec, int id, int src,
> snd_soc_update_bits(codec, WM8994_FLL1_CONTROL_1 + reg_offset,
> WM8994_FLL1_ENA | WM8994_FLL1_FRAC,
> reg);
> +
> + msleep(5);
> }
>
> wm8994->fll[id].in = freq_in;
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2011-07-04 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 0:35 [PATCH] ASoC: Ensure we delay long enough for WM8994 FLL to lock when starting Mark Brown
2011-07-03 23:59 ` Sangbeom Kim
2011-07-04 0:44 ` Mark Brown
2011-07-04 1:13 ` Sangbeom Kim
2011-07-04 2:07 ` Mark Brown
2011-07-04 9:44 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E118B8C.5020600@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox