From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: Fix SPI driver binding for WM8987
Date: Tue, 9 Aug 2011 13:17:02 +0100 [thread overview]
Message-ID: <4E41253E.2040407@ti.com> (raw)
In-Reply-To: <1312362661-4544-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 03/08/11 10:11, Mark Brown wrote:
> As we had no id_table only the driver name would be matched against
> meaning that WM8987 devices wouldn't be bound.
>
Subject line is for wrong codec but otherwise (with new subject line)
Acked-by: Liam Girdwood <lrg@ti.com>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8750.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8750.c b/sound/soc/codecs/wm8750.c
> index 6cbf51b..2bb7bea 100644
> --- a/sound/soc/codecs/wm8750.c
> +++ b/sound/soc/codecs/wm8750.c
> @@ -779,11 +779,18 @@ static int __devexit wm8750_spi_remove(struct spi_device *spi)
> return 0;
> }
>
> +static const struct spi_device_id wm8750_spi_ids[] = {
> + { "wm8750", 0 },
> + { "wm8987", 0 },
> +};
> +MODULE_DEVICE_TABLE(spi, wm8750_spi_id);
> +
> static struct spi_driver wm8750_spi_driver = {
> .driver = {
> - .name = "wm8750-codec",
> + .name = "wm8750",
> .owner = THIS_MODULE,
> },
> + .id_table = wm8750_spi_ids,
> .probe = wm8750_spi_probe,
> .remove = __devexit_p(wm8750_spi_remove),
> };
next prev parent reply other threads:[~2011-08-09 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 9:11 [PATCH] ASoC: Fix SPI driver binding for WM8987 Mark Brown
2011-08-09 12:17 ` Liam Girdwood [this message]
2011-08-09 15:05 ` Mark Brown
2011-08-09 15:28 ` Liam Girdwood
2011-08-09 15:31 ` Mark Brown
2011-08-09 15:41 ` Liam Girdwood
2011-08-09 15:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E41253E.2040407@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox