Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: "Ujfalusi, Peter" <peter.ujfalusi@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	"Lopez Cruz, Misael" <misael.lopez@ti.com>
Subject: Re: [PATCH] ASoC: sdp4430: Fix string for FM input name
Date: Tue, 9 Aug 2011 13:47:15 +0100	[thread overview]
Message-ID: <4E412C53.6050507@ti.com> (raw)
In-Reply-To: <3256303.St6Oti5sp6@barack>

On 09/08/11 08:29, Ujfalusi, Peter wrote:
> Hi Mark, Liam,
> 
> On Wednesday 06 July 2011 20:18:05 Ujfalusi, Peter wrote:
>> The name contains invalid valid character (/), which
>> causes problems when trying to create the debugfs
>> directory structure:
>> ASoC: Failed to create Aux/FM Stereo In debugfs file
> 
> Can you take a look at this patch?
> I think this shall go for 3.1 as a fix.
> 

I'll pull this with your others once Mark gets a chance to have a look.

> Thanks,
> Peter
> 
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>>  sound/soc/omap/sdp4430.c |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/omap/sdp4430.c b/sound/soc/omap/sdp4430.c
>> index a951774..d462f1a 100644
>> --- a/sound/soc/omap/sdp4430.c
>> +++ b/sound/soc/omap/sdp4430.c
>> @@ -88,7 +88,7 @@ static const struct snd_soc_dapm_widget
>> sdp4430_twl6040_dapm_widgets[] = { SND_SOC_DAPM_MIC("Headset Mic", NULL),
>>  	SND_SOC_DAPM_HP("Headset Stereophone", NULL),
>>  	SND_SOC_DAPM_SPK("Earphone Spk", NULL),
>> -	SND_SOC_DAPM_INPUT("Aux/FM Stereo In"),
>> +	SND_SOC_DAPM_INPUT("FM Stereo In"),
>>  };
>>
>>  static const struct snd_soc_dapm_route audio_map[] = {
>> @@ -113,8 +113,8 @@ static const struct snd_soc_dapm_route audio_map[] = {
>>  	{"Earphone Spk", NULL, "EP"},
>>
>>  	/* Aux/FM Stereo In: AFML, AFMR */
>> -	{"AFML", NULL, "Aux/FM Stereo In"},
>> -	{"AFMR", NULL, "Aux/FM Stereo In"},
>> +	{"AFML", NULL, "FM Stereo In"},
>> +	{"AFMR", NULL, "FM Stereo In"},
>>  };
>>
>>  static int sdp4430_twl6040_init(struct snd_soc_pcm_runtime *rtd)

  reply	other threads:[~2011-08-09 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-06 18:18 [PATCH] ASoC: sdp4430: Fix string for FM input name Peter Ujfalusi
2011-08-09  7:29 ` Péter Ujfalusi
2011-08-09 12:47   ` Liam Girdwood [this message]
2011-08-09 14:33   ` Mark Brown
2011-09-26 10:37 ` Péter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E412C53.6050507@ti.com \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=misael.lopez@ti.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox