From: Liam Girdwood <lrg@ti.com>
To: Lu Guanqun <guanqun.lu@intel.com>
Cc: ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] alsaucm: exit when user wants 'help' and 'version'
Date: Fri, 19 Aug 2011 13:30:17 +0100 [thread overview]
Message-ID: <4E4E5759.6090909@ti.com> (raw)
In-Reply-To: <20110819060035.3879.44369.stgit@localhost6.localdomain6>
On 19/08/11 07:00, Lu Guanqun wrote:
> When user specifies option 'help' or 'version', the program exists immediately.
> This is more expected way than the current one.
>
> Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
> ---
> alsaucm/usecase.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/alsaucm/usecase.c b/alsaucm/usecase.c
> index 1c94680..14a4be0 100644
> --- a/alsaucm/usecase.c
> +++ b/alsaucm/usecase.c
> @@ -395,10 +395,10 @@ int main(int argc, char *argv[])
> switch (c) {
> case 'h':
> dump_help(context);
> - break;
> + my_exit(context, EXIT_SUCCESS);
> case OPT_VERSION:
> printf("%s: version " SND_UTIL_VERSION_STR "\n", command);
> - break;
> + my_exit(context, EXIT_SUCCESS);
> case 'c':
> if (context->card)
> free(context->card);
>
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2011-08-19 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 6:00 [PATCH] alsaucm: exit when user wants 'help' and 'version' Lu Guanqun
2011-08-19 12:30 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4E5759.6090909@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=guanqun.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox