From: Liam Girdwood <lrg@ti.com>
To: Lu Guanqun <guanqun.lu@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>, ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ucm: change msleep to usleep
Date: Fri, 19 Aug 2011 17:12:52 +0100 [thread overview]
Message-ID: <4E4E8B84.1070700@ti.com> (raw)
In-Reply-To: <s5hpqk1luh6.wl%tiwai@suse.de>
On 19/08/11 08:40, Takashi Iwai wrote:
> At Fri, 19 Aug 2011 15:22:17 +0800,
> Lu Guanqun wrote:
>>
>> In file src/ucm/parser.c:
>> if (strcmp(cmd, "usleep") == 0) {
>> string `usleep' is compared, however, in the comment and example conf file,
>> `msleep' is used, it's better to unify them all.
>
> Don't we scale the value appropriately (although it's just a demo)?
>
msleep is more useful here for pop prevention, but I suppose usleep could be useful too.
Could you redo to support both usleep and msleep ?
Thanks
Liam
next prev parent reply other threads:[~2011-08-19 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 7:22 [PATCH] ucm: change msleep to usleep Lu Guanqun
2011-08-19 7:40 ` Takashi Iwai
2011-08-19 8:13 ` Lu Guanqun
2011-08-19 8:21 ` Takashi Iwai
2011-08-19 16:12 ` Liam Girdwood [this message]
2011-08-22 1:25 ` [PATCH] ucm: add another sequence 'msleep' Lu Guanqun
2011-08-22 5:35 ` [PATCH v2] " Lu Guanqun
2011-08-22 10:39 ` Liam Girdwood
2011-08-22 10:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4E8B84.1070700@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=guanqun.lu@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox