From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: Ensure we only run Speyside WM8962 bias level callbacks once
Date: Mon, 22 Aug 2011 11:23:23 +0100 [thread overview]
Message-ID: <4E522E1B.4050907@ti.com> (raw)
In-Reply-To: <1313925642-7555-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 21/08/11 12:20, Mark Brown wrote:
> We get called once per DAPM context but only need to run once. When DAPM
> was serialized this was a series of noops but now it can run in parallel
> we need to take proper care.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/samsung/speyside_wm8962.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/samsung/speyside_wm8962.c b/sound/soc/samsung/speyside_wm8962.c
> index 753e1c2..3820a6b 100644
> --- a/sound/soc/samsung/speyside_wm8962.c
> +++ b/sound/soc/samsung/speyside_wm8962.c
> @@ -23,6 +23,9 @@ static int speyside_wm8962_set_bias_level(struct snd_soc_card *card,
> struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
> int ret;
>
> + if (dapm->dev != codec_dai->dev)
> + return 0;
> +
> switch (level) {
> case SND_SOC_BIAS_PREPARE:
> if (dapm->bias_level == SND_SOC_BIAS_STANDBY) {
> @@ -57,6 +60,9 @@ static int speyside_wm8962_set_bias_level_post(struct snd_soc_card *card,
> struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
> int ret;
>
> + if (dapm->dev != codec_dai->dev)
> + return 0;
> +
> switch (level) {
> case SND_SOC_BIAS_STANDBY:
> ret = snd_soc_dai_set_sysclk(codec_dai, WM8962_SYSCLK_MCLK,
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2011-08-22 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 11:20 [PATCH] ASoC: Ensure we only run Speyside WM8962 bias level callbacks once Mark Brown
2011-08-22 10:23 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E522E1B.4050907@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox