From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: Report IRQ_NONE when we don't see an interrupt from WM8962
Date: Mon, 22 Aug 2011 11:25:17 +0100 [thread overview]
Message-ID: <4E522E8D.1000003@ti.com> (raw)
In-Reply-To: <1313927925-11523-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 21/08/11 12:58, Mark Brown wrote:
> This should never happen with level triggered IRQs.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8962.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
> index 0c61c2f..b877fa9 100644
> --- a/sound/soc/codecs/wm8962.c
> +++ b/sound/soc/codecs/wm8962.c
> @@ -3577,6 +3577,9 @@ static irqreturn_t wm8962_irq(int irq, void *data)
> active = snd_soc_read(codec, WM8962_INTERRUPT_STATUS_2);
> active &= ~mask;
>
> + if (!active)
> + return IRQ_NONE;
> +
> /* Acknowledge the interrupts */
> snd_soc_write(codec, WM8962_INTERRUPT_STATUS_2, active);
>
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2011-08-22 10:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 11:58 [PATCH] ASoC: Report IRQ_NONE when we don't see an interrupt from WM8962 Mark Brown
2011-08-22 10:25 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E522E8D.1000003@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox