From: Lars-Peter Clausen <lars@metafoo.de>
To: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"Girdwood, Liam" <lrg@ti.com>,
"Lopez Cruz, Misael" <misael.lopez@ti.com>
Subject: Re: [PATCH v2 2/2] ASoC: omap-mcpdm: Replace legacy driver
Date: Mon, 22 Aug 2011 15:39:15 +0200 [thread overview]
Message-ID: <4E525C03.6090405@metafoo.de> (raw)
In-Reply-To: <1452269.zSYBkDql26@barack>
On 08/22/2011 01:34 PM, Péter Ujfalusi wrote:
> On Friday 19 August 2011 10:49:08 Lars-Peter Clausen wrote:
>> sorry:
>> struct omap_mcpdm *mcpdm = snd_soc_platform_get_drvdata(w->platform);
>>
>>> This would avoid having to add the private_data field to the widget
>>> struct. In it's current form it will only really work, if there is just
>>> one instance of the driver using the widget. And if that's the case you
>>> can use a global variable directly anyway.
>
> The other option was to use global variable to get the *mcpdm for the widget.
> Generally I try to avoid global variables as much as I can, since the use of
> them looks really hackish.
omap_mcpdm_widgets is a global variable. You assign to it in asoc_mcpdm_probe
and read from it in omap_mcpdm_add_dapm_widget. The fact that you hide your
*mcpdm in a void pointer doesn't make it less hackish.
next prev parent reply other threads:[~2011-08-22 13:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 7:41 [PATCH v2 0/2] ASoC: omap-mcpdm: New McPDM driver Peter Ujfalusi
2011-08-19 7:41 ` [PATCH v2 1/2] ASoC: DAPM: Add private data pointer for DAPM widget Peter Ujfalusi
2011-08-20 7:02 ` Mark Brown
2011-08-22 13:33 ` Péter Ujfalusi
2011-08-22 22:32 ` Mark Brown
2011-08-19 7:41 ` [PATCH v2 2/2] ASoC: omap-mcpdm: Replace legacy driver Peter Ujfalusi
2011-08-19 8:38 ` Lars-Peter Clausen
2011-08-19 8:49 ` Lars-Peter Clausen
2011-08-19 12:38 ` Liam Girdwood
2011-08-19 13:13 ` Lars-Peter Clausen
2011-08-19 16:59 ` Liam Girdwood
2011-08-22 11:34 ` Péter Ujfalusi
2011-08-22 13:04 ` Mark Brown
2011-08-22 13:39 ` Lars-Peter Clausen [this message]
2011-08-23 6:49 ` Péter Ujfalusi
2011-08-23 10:14 ` Lars-Peter Clausen
2011-08-26 8:08 ` Péter Ujfalusi
2011-08-19 13:33 ` Paul Menzel
2011-08-20 7:01 ` Mark Brown
2011-08-23 7:52 ` Péter Ujfalusi
2011-08-23 10:57 ` Mark Brown
2011-08-26 8:01 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E525C03.6090405@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).