alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH] ASoC: MPC5200: replace of_device with platform_device
Date: Wed, 24 Aug 2011 14:46:17 -0500	[thread overview]
Message-ID: <4E555509.7080905@freescale.com> (raw)
In-Reply-To: <20110824155719.GC16653@opensource.wolfsonmicro.com>

Mark Brown wrote:
> On Wed, Aug 24, 2011 at 10:50:02AM -0500, Timur Tabi wrote:
>> Mark Brown wrote:
>>> I'll apply it for 3.1, I was asking because I didn't know if the API
>>> change happened in 3.1 or was only present 3.2.  Thanks.
> 
>> I think the change happened in 3.0, or maybe even earlier.
> 
> Oh dear.  Can you check please, if it did there should be a CC stable?

Apparently it was broken from the start, as git-bisect blames this commit:

f0fba2ad1b6b53d5360125c41953b7afcd6deff0 is the first bad commit
commit f0fba2ad1b6b53d5360125c41953b7afcd6deff0
Author: Liam Girdwood <lrg@slimlogic.co.uk>
Date:   Wed Mar 17 20:15:21 2010 +0000

    ASoC: multi-component - ASoC Multi-Component Support

I suspect the problem is that the defconfig for the MPC5200 doesn't actually
enable audio, so when that platform was tested, none of the ASoC code was
actually compiled.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2011-08-24 19:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23 21:48 [PATCH] ASoC: MPC5200: replace of_device with platform_device Timur Tabi
2011-08-24  9:17 ` Mark Brown
2011-08-24 15:35   ` Timur Tabi
2011-08-24 15:44     ` Mark Brown
2011-08-24 15:50       ` Timur Tabi
2011-08-24 15:57         ` Mark Brown
2011-08-24 19:46           ` Timur Tabi [this message]
2011-08-25  9:34             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E555509.7080905@freescale.com \
    --to=timur@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).