Re: [PATCH 1/3] ASoC: snd_soc_codec_{readable, writable}_register change default to true

[Liam Girdwood <lrg@ti.com>]

On 27/08/11 17:24, Lars-Peter Clausen wrote:
> Change the default return value of snd_soc_codec_{readable,writable}_register to
> true when no codec specific callback for this function is given. Otherwise all
> registers of that codec will neither be readable nor writable, which is most
> certainly not what we want.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>  sound/soc/soc-core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index fd173f6..4065d4e 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1635,7 +1635,7 @@ int snd_soc_codec_readable_register(struct snd_soc_codec *codec,
>  	if (codec->readable_register)
>  		return codec->readable_register(codec, reg);
>  	else
> -		return 0;
> +		return 1;
>  }
>  EXPORT_SYMBOL_GPL(snd_soc_codec_readable_register);
>  
> @@ -1653,7 +1653,7 @@ int snd_soc_codec_writable_register(struct snd_soc_codec *codec,
>  	if (codec->writable_register)
>  		return codec->writable_register(codec, reg);
>  	else
> -		return 0;
> +		return 1;
>  }
>  EXPORT_SYMBOL_GPL(snd_soc_codec_writable_register);
>  

All

Acked-by: Liam Girdwood <lrg@ti.com>