From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [RFC v2 PATCH 1/1] ASoC: soc-core: symmetry checking for each DAIs separately Date: Wed, 31 Aug 2011 11:52:53 +0100 Message-ID: <4E5E1285.8020508@ti.com> References: <1314609314-22162-1-git-send-email-b29396@freescale.com> <65EE16ACC360FA4D99C96DC085B3F77222AE40@039-SN1MPN1-001.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by alsa0.perex.cz (Postfix) with ESMTP id 4C5871038C7 for ; Wed, 31 Aug 2011 12:53:00 +0200 (CEST) In-Reply-To: <65EE16ACC360FA4D99C96DC085B3F77222AE40@039-SN1MPN1-001.039d.mgd.msft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tabi Timur-B04825 Cc: "alsa-devel@alsa-project.org" , "lars@metafoo.de" , "s.hauer@pengutronix.de" , "broonie@opensource.wolfsonmicro.com" , "w.sang@pengutronix.de" , Dong Aisheng-B29396 , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org On 30/08/11 03:54, Dong Aisheng-B29396 wrote: >> -----Original Message----- >> From: Tabi Timur-B04825 >> Sent: Tuesday, August 30, 2011 4:35 AM >> To: Dong Aisheng-B29396 >> Cc: alsa-devel@alsa-project.org; lars@metafoo.de; s.hauer@pengutronix.de; >> broonie@opensource.wolfsonmicro.com; w.sang@pengutronix.de; lrg@ti.com; >> linux-arm-kernel@lists.infradead.org >> Subject: Re: [alsa-devel] [RFC v2 PATCH 1/1] ASoC: soc-core: symmetry >> checking for each DAIs separately >> >> On Mon, Aug 29, 2011 at 4:15 AM, Dong Aisheng >> wrote: >>> The orginal code does not cover the case that one DAI such as codec >>> may be shared between other two DAIs(CPU). >> >> Can you give me an example of how this can occur? >> > > Pls check the following case used in mx28evk. > static struct snd_soc_dai_link mxs_sgtl5000_dai[] = { > { > .name = "HiFi Tx", > .stream_name = "HiFi Playback", > .codec_dai_name = "sgtl5000", > .codec_name = "sgtl5000.0-000a", > .cpu_dai_name = "mxs-saif.0", > .platform_name = "mxs-pcm-audio.0", > .ops = &mxs_sgtl5000_hifi_ops, > }, { > .name = "HiFi Rx", > .stream_name = "HiFi Capture", > .codec_dai_name = "sgtl5000", > .codec_name = "sgtl5000.0-000a", > .cpu_dai_name = "mxs-saif.1", > .platform_name = "mxs-pcm-audio.1", > .ops = &mxs_sgtl5000_hifi_ops, > }, > }; > You can also refer to: > http://thread.gmane.org/gmane.linux.ports.arm.kernel/129789/focus=129839 > Timur, iirc your driver has some special symmetry requirement (maybe something todo with having 2 DAIs) ? I assume this is OK for you too ? Acked-by: Liam Girdwood Liam