From: Clemens Ladisch <clemens@ladisch.de>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: alsa-devel@alsa-project.org,
"Ondrej Zary" <linux@rainbow-software.org>,
"Dan Carpenter" <error27@gmail.com>,
"Takashi Iwai" <tiwai@suse.de>, "Jiri Kosina" <jkosina@suse.cz>,
linux-kernel@vger.kernel.org, "Andreas Mohr" <andi@lisas.de>,
"Lucas De Marchi" <lucas.demarchi@profusion.mobi>,
"Julia Lawall" <julia@diku.dk>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Joe Perches" <joe@perches.com>,
tglx@linutronix.de, mingo@elte.hu
Subject: Re: [RFC] [PATCH 02/62] mpu401:snd_mpu401_uart_new(): split semantic of irq_flags
Date: Thu, 08 Sep 2011 12:53:14 +0200 [thread overview]
Message-ID: <4E689E9A.8000407@ladisch.de> (raw)
In-Reply-To: <1315383059-3673-3-git-send-email-yong.zhang0@gmail.com>
Yong Zhang wrote:
> Now snd_mpu401_uart_new() parameter 'irq_flags' take two role
> in it: one is the condition to request_irq and the other is
> the real irq_flags which will be transfered to request_irq().
>
> So add another parameter 'want_irq' to take the role of the
> first one, this will make it easy to remove IRQF_DISABLED.
Please note that the irq number is also intended to pass this
information:
> * @irq: the irq number, -1 if no interrupt for mpu
> ...
> - if (irq >= 0 && irq_flags) {
> if (request_irq(irq, snd_mpu401_uart_interrupt, irq_flags,
Of course, most of snd_mpu401_uart_new()'s users get this wrong and use
0 instead of -1, relying on the irq_flags parameter only. But if these
are fixed to use irq == -1, we get the same effect without having to
introduce another parameter.
Regards,
Clemens
next prev parent reply other threads:[~2011-09-08 10:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1315383059-3673-1-git-send-email-yong.zhang0@gmail.com>
2011-09-07 8:10 ` [PATCH 60/62] sound: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-07 8:36 ` Péter Ujfalusi
2011-09-07 17:12 ` Mark Brown
[not found] ` <1315383059-3673-3-git-send-email-yong.zhang0@gmail.com>
2011-09-08 10:53 ` Clemens Ladisch [this message]
2011-09-08 13:37 ` [RFC] [PATCH 02/62] mpu401:snd_mpu401_uart_new(): split semantic of irq_flags Yong Zhang
2011-09-08 13:58 ` Clemens Ladisch
2011-09-08 14:45 ` Yong Zhang
2011-09-08 20:27 ` Clemens Ladisch
2011-09-09 1:31 ` Yong Zhang
2011-09-11 15:10 ` Clemens Ladisch
2011-09-12 10:47 ` Takashi Iwai
2011-09-12 13:16 ` Clemens Ladisch
2011-09-12 20:23 ` Clemens Ladisch
2011-09-13 7:12 ` Takashi Iwai
2011-09-13 8:17 ` Clemens Ladisch
2011-09-13 9:24 ` Clemens Ladisch
2011-09-14 8:49 ` Yong Zhang
2011-09-14 9:06 ` Takashi Iwai
2011-09-14 9:15 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E689E9A.8000407@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=andi@lisas.de \
--cc=error27@gmail.com \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox