From: Bas Vermeulen <Bas.Vermeulen@novero.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: [ASoC] 88pm860x - Allow independent use of I2S capture and playback
Date: Mon, 19 Sep 2011 13:35:57 +0200 [thread overview]
Message-ID: <4E77291D.10107@novero.com> (raw)
In-Reply-To: <20110917133206.GB3798@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On 09/17/2011 03:32 PM, Mark Brown wrote:
> On Fri, Sep 16, 2011 at 04:07:13PM +0200, Bas Vermeulen wrote:
>> Note that in order to be able to use playback and capture independently
>> on the I2S interface (within reason, it is not possible to use a
>> different rate for instance), I had to add a SUPPLY control to the dapm
>> widgets that turns on the I2S clock when needed.
> Can you send a patch for this please?
Attached is a patch to turn the I2S clock on for both of I2S capture and
playback instead of just playback.
Regards,
Bas Vermeulen
[-- Attachment #2: 0001-ASoC-88pm860x-codec-Allow-independent-use-of-both-I2.patch --]
[-- Type: text/x-patch, Size: 1756 bytes --]
>From a02c4f024daeae6f0708467bc1adbe20bc7458bb Mon Sep 17 00:00:00 2001
From: Bas Vermeulen <bas.vermeulen@novero.com>
Date: Mon, 19 Sep 2011 12:57:09 +0200
Subject: [PATCH 1/2] [ASoC] 88pm860x-codec - Allow independent use of both I2S playback and capture
Introduce a I2S CLK supply so playback and capture can operate independently.
Signed-off-by: Bas Vermeulen <bas.vermeulen@novero.com>
---
sound/soc/codecs/88pm860x-codec.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/88pm860x-codec.c b/sound/soc/codecs/88pm860x-codec.c
index 1924157..0198dbb 100644
--- a/sound/soc/codecs/88pm860x-codec.c
+++ b/sound/soc/codecs/88pm860x-codec.c
@@ -772,11 +772,12 @@ static const struct snd_soc_dapm_widget pm860x_dapm_widgets[] = {
SND_SOC_DAPM_AIF_IN("I2S DIN", "I2S Playback", 0,
- PM860X_DAC_EN_2, 0, 0),
+ SND_SOC_NOPM, 0, 0),
SND_SOC_DAPM_AIF_IN("I2S DIN1", "I2S Playback", 0,
- PM860X_DAC_EN_2, 0, 0),
+ SND_SOC_NOPM, 0, 0),
SND_SOC_DAPM_AIF_OUT("I2S DOUT", "I2S Capture", 0,
PM860X_I2S_IFACE_3, 5, 1),
+ SND_SOC_DAPM_SUPPLY("I2S CLK", PM860X_DAC_EN_2, 0, 0, NULL, 0),
SND_SOC_DAPM_MUX("I2S Mic Mux", SND_SOC_NOPM, 0, 0, &i2s_mic_mux),
SND_SOC_DAPM_MUX("ADC Left Mux", SND_SOC_NOPM, 0, 0, &adcl_mux),
SND_SOC_DAPM_MUX("ADC Right Mux", SND_SOC_NOPM, 0, 0, &adcr_mux),
@@ -868,6 +869,11 @@ static const struct snd_soc_dapm_route audio_map[] = {
{"Left ADC", NULL, "Left ADC MOD"},
{"Right ADC", NULL, "Right ADC MOD"},
+ /* I2S Clock */
+ {"I2S DIN", NULL, "I2S CLK"},
+ {"I2S DIN1", NULL, "I2S CLK"},
+ {"I2S DOUT", NULL, "I2S CLK"},
+
/* PCM/AIF1 Inputs */
{"PCM SDO", NULL, "ADC Left Mux"},
{"PCM SDO", NULL, "ADCR EC Mux"},
--
1.7.0.4
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2011-09-19 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 14:07 ASoC/DAPM: How to make the DAPM routing complete? Bas Vermeulen
2011-09-17 13:32 ` Mark Brown
2011-09-19 11:35 ` Bas Vermeulen [this message]
2011-09-20 11:34 ` [ASoC] 88pm860x - Allow independent use of I2S capture and playback Mark Brown
2011-09-21 14:55 ` Mark Brown
2011-09-19 11:38 ` [ASoC] 88pm860x - Incorporate the marvell errata regarding Audio Power-up Delay Bas Vermeulen
2011-09-20 11:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E77291D.10107@novero.com \
--to=bas.vermeulen@novero.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).