* [PATCH] ASoC: adau1701: Initialize codec->control_data before using it
@ 2011-09-28 7:21 Axel Lin
2011-09-28 7:24 ` Axel Lin
2011-09-28 7:26 ` Lars-Peter Clausen
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-09-28 7:21 UTC (permalink / raw)
To: linux-kernel
Cc: Cliff Cai, Lars-Peter Clausen, Liam Girdwood, Mark Brown,
alsa-devel
Currently codec->control_data is not initialized before calling
process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE).
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/adau1701.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
index b7e4cc7..8b7e1c5 100644
--- a/sound/soc/codecs/adau1701.c
+++ b/sound/soc/codecs/adau1701.c
@@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec)
int ret;
codec->dapm.idle_bias_off = 1;
+ codec->control_data = to_i2c_client(codec->dev);
ret = adau1701_load_firmware(codec);
if (ret)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: adau1701: Initialize codec->control_data before using it
2011-09-28 7:21 [PATCH] ASoC: adau1701: Initialize codec->control_data before using it Axel Lin
@ 2011-09-28 7:24 ` Axel Lin
2011-09-28 7:26 ` Lars-Peter Clausen
1 sibling, 0 replies; 3+ messages in thread
From: Axel Lin @ 2011-09-28 7:24 UTC (permalink / raw)
To: linux-kernel
Cc: Cliff Cai, Lars-Peter Clausen, Liam Girdwood, Mark Brown,
alsa-devel
2011/9/28 Axel Lin <axel.lin@gmail.com>:
> Currently codec->control_data is not initialized before calling
> process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE).
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
This one is a v2 of original patch.
Sorry, forgot to add v2 in the subject line.
> sound/soc/codecs/adau1701.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
> index b7e4cc7..8b7e1c5 100644
> --- a/sound/soc/codecs/adau1701.c
> +++ b/sound/soc/codecs/adau1701.c
> @@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec)
> int ret;
>
> codec->dapm.idle_bias_off = 1;
> + codec->control_data = to_i2c_client(codec->dev);
>
> ret = adau1701_load_firmware(codec);
> if (ret)
> --
> 1.7.4.1
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: adau1701: Initialize codec->control_data before using it
2011-09-28 7:21 [PATCH] ASoC: adau1701: Initialize codec->control_data before using it Axel Lin
2011-09-28 7:24 ` Axel Lin
@ 2011-09-28 7:26 ` Lars-Peter Clausen
1 sibling, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2011-09-28 7:26 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Mark Brown, linux-kernel, Liam Girdwood
On 09/28/2011 09:21 AM, Axel Lin wrote:
> Currently codec->control_data is not initialized before calling
> process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE).
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks
> ---
> sound/soc/codecs/adau1701.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
> index b7e4cc7..8b7e1c5 100644
> --- a/sound/soc/codecs/adau1701.c
> +++ b/sound/soc/codecs/adau1701.c
> @@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec)
> int ret;
>
> codec->dapm.idle_bias_off = 1;
> + codec->control_data = to_i2c_client(codec->dev);
>
> ret = adau1701_load_firmware(codec);
> if (ret)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-28 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-28 7:21 [PATCH] ASoC: adau1701: Initialize codec->control_data before using it Axel Lin
2011-09-28 7:24 ` Axel Lin
2011-09-28 7:26 ` Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).