From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel@vger.kernel.org,
Jassi Brar <jassisinghbrar@gmail.com>,
Sangbeom Kim <sbkim73@samsung.com>, Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
Date: Mon, 3 Oct 2011 12:03:19 -0400 [thread overview]
Message-ID: <4E89DCC7.4010703@windriver.com> (raw)
In-Reply-To: <20111003103026.GB23811@sirena.org.uk>
On 11-10-03 06:30 AM, Mark Brown wrote:
> On Mon, Oct 03, 2011 at 08:17:21AM +0800, Axel Lin wrote:
>> 2011/10/3 Mark Brown <broonie@opensource.wolfsonmicro.com>:
>
>>> What tree is this for? ?My primary development platform is based on this
>>> driver, I'd expect to have noticed any build issues and I rather suspect
>>> this isn't what you're supposed to do after all the module.h stuff has
>>> settled down.
>
>> I got the build error on linux-next (20110930).
>
> That's exactly what I'm running at the minute with no problem...
Then I'm guessing you don't have the option for it enabled (as
the s3c2410_defconfig doesn't enable it, it seems).
I reproduced it with the following commands:
28 git checkout next-20110930
29 mkdir ../arm-sam
30 make O=../arm-sam s3c2410_defconfig
31 nice make O=../arm-foo/ sound/soc/samsung/s3c-i2s-v2.o
Thanks Axel, I'll squish this into the commit that adds module.h
to all the other sound drivers that have it missing.
Paul.
next prev parent reply other threads:[~2011-10-03 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 13:34 [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h Axel Lin
2011-10-02 18:26 ` Mark Brown
2011-10-03 0:17 ` Axel Lin
2011-10-03 10:30 ` Mark Brown
2011-10-03 16:03 ` Paul Gortmaker [this message]
2011-10-03 17:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E89DCC7.4010703@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).