From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h Date: Mon, 3 Oct 2011 12:03:19 -0400 Message-ID: <4E89DCC7.4010703@windriver.com> References: <1317562466.4996.2.camel@phoenix> <20111002182605.GC2857@opensource.wolfsonmicro.com> <20111003103026.GB23811@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111003103026.GB23811@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Axel Lin , linux-kernel@vger.kernel.org, Jassi Brar , Sangbeom Kim , Liam Girdwood , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 11-10-03 06:30 AM, Mark Brown wrote: > On Mon, Oct 03, 2011 at 08:17:21AM +0800, Axel Lin wrote: >> 2011/10/3 Mark Brown : > >>> What tree is this for? ?My primary development platform is based on this >>> driver, I'd expect to have noticed any build issues and I rather suspect >>> this isn't what you're supposed to do after all the module.h stuff has >>> settled down. > >> I got the build error on linux-next (20110930). > > That's exactly what I'm running at the minute with no problem... Then I'm guessing you don't have the option for it enabled (as the s3c2410_defconfig doesn't enable it, it seems). I reproduced it with the following commands: 28 git checkout next-20110930 29 mkdir ../arm-sam 30 make O=../arm-sam s3c2410_defconfig 31 nice make O=../arm-foo/ sound/soc/samsung/s3c-i2s-v2.o Thanks Axel, I'll squish this into the commit that adds module.h to all the other sound drivers that have it missing. Paul.