* [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to snd_soc_read
@ 2011-10-14 1:35 Axel Lin
2011-10-14 1:37 ` [PATCH 2/3] ASoC: tlv320aic3x: " Axel Lin
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Axel Lin @ 2011-10-14 1:35 UTC (permalink / raw)
To: linux-kernel; +Cc: Arnaud Patard, Liam Girdwood, Mark Brown, alsa-devel
codec->hw_read is broken now, let's covert to snd_soc_read.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/alc5623.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/alc5623.c b/sound/soc/codecs/alc5623.c
index 557b3af..984b14b 100644
--- a/sound/soc/codecs/alc5623.c
+++ b/sound/soc/codecs/alc5623.c
@@ -53,8 +53,10 @@ static void alc5623_fill_cache(struct snd_soc_codec *codec)
u16 *cache = codec->reg_cache;
/* not really efficient ... */
+ codec->cache_bypass = 1;
for (i = 0 ; i < codec->driver->reg_cache_size ; i += step)
- cache[i] = codec->hw_read(codec, i);
+ cache[i] = snd_soc_read(codec, i);
+ codec->cache_bypass = 0;
}
static inline int alc5623_reset(struct snd_soc_codec *codec)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/3] ASoC: tlv320aic3x: Convert codec->hw_read to snd_soc_read
2011-10-14 1:35 [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to snd_soc_read Axel Lin
@ 2011-10-14 1:37 ` Axel Lin
2011-10-14 19:35 ` Mark Brown
2011-10-14 1:37 ` [PATCH 3/3] ASoC: wm8991: " Axel Lin
2011-10-14 19:34 ` [PATCH 1/3] ASoC: alc5623: " Mark Brown
2 siblings, 1 reply; 9+ messages in thread
From: Axel Lin @ 2011-10-14 1:37 UTC (permalink / raw)
To: linux-kernel; +Cc: Vladimir Barinov, alsa-devel, Mark Brown, Liam Girdwood
codec->hw_read is broken now, let's covert to snd_soc_read.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/tlv320aic3x.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index be55b7f..7a49390 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -137,7 +137,10 @@ static int aic3x_read(struct snd_soc_codec *codec, unsigned int reg,
if (reg >= AIC3X_CACHEREGNUM)
return -1;
- *value = codec->hw_read(codec, reg);
+ codec->cache_bypass = 1;
+ *value = snd_soc_read(codec, reg);
+ codec->cache_bypass = 0;
+
cache[reg] = *value;
return 0;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] ASoC: tlv320aic3x: Convert codec->hw_read to snd_soc_read
2011-10-14 1:37 ` [PATCH 2/3] ASoC: tlv320aic3x: " Axel Lin
@ 2011-10-14 19:35 ` Mark Brown
2011-10-14 19:44 ` Vladimir Barinov
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2011-10-14 19:35 UTC (permalink / raw)
To: Axel Lin; +Cc: Vladimir Barinov, alsa-devel, linux-kernel, Liam Girdwood
On Fri, Oct 14, 2011 at 09:37:00AM +0800, Axel Lin wrote:
> codec->hw_read is broken now, let's covert to snd_soc_read.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks. You really should CC the TI guys on this driver,
especially Jarkko, as they have been doing most of the work on it.
Vladimir hasn't been very active since the initial contribution.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] ASoC: tlv320aic3x: Convert codec->hw_read to snd_soc_read
2011-10-14 19:35 ` Mark Brown
@ 2011-10-14 19:44 ` Vladimir Barinov
0 siblings, 0 replies; 9+ messages in thread
From: Vladimir Barinov @ 2011-10-14 19:44 UTC (permalink / raw)
To: Mark Brown
Cc: Axel Lin, linux-kernel, Vladimir Barinov, Liam Girdwood,
alsa-devel
Mark Brown wrote:
> On Fri, Oct 14, 2011 at 09:37:00AM +0800, Axel Lin wrote:
>
>> codec->hw_read is broken now, let's covert to snd_soc_read.
>>
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>>
>
> Applied, thanks. You really should CC the TI guys on this driver,
> especially Jarkko, as they have been doing most of the work on it.
> Vladimir hasn't been very active since the initial contribution.
>
Yes, please, since I have no actual h/w and can't maintain the codec
driver anymore.
Also the layer specific changes (not h/w related) should be reviewed by
ASoC guru and not me.
Regards,
Vladimir
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] ASoC: wm8991: Convert codec->hw_read to snd_soc_read
2011-10-14 1:35 [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to snd_soc_read Axel Lin
2011-10-14 1:37 ` [PATCH 2/3] ASoC: tlv320aic3x: " Axel Lin
@ 2011-10-14 1:37 ` Axel Lin
2011-10-14 1:39 ` [PATCH 3/3] ASoC: wm8961: " Axel Lin
2011-10-14 1:41 ` [PATCH 3/3] ASoC: wm8991: " Axel Lin
2011-10-14 19:34 ` [PATCH 1/3] ASoC: alc5623: " Mark Brown
2 siblings, 2 replies; 9+ messages in thread
From: Axel Lin @ 2011-10-14 1:37 UTC (permalink / raw)
To: linux-kernel; +Cc: alsa-devel, Mark Brown, Liam Girdwood
codec->hw_read is broken now, let's covert to snd_soc_read.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/wm8961.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8961.c b/sound/soc/codecs/wm8961.c
index cdee810..9568c8a 100644
--- a/sound/soc/codecs/wm8961.c
+++ b/sound/soc/codecs/wm8961.c
@@ -974,7 +974,9 @@ static int wm8961_probe(struct snd_soc_codec *codec)
}
/* This isn't volatile - readback doesn't correspond to write */
- reg = codec->hw_read(codec, WM8961_RIGHT_INPUT_VOLUME);
+ codec->cache_bypass = 1;
+ reg = snd_soc_read(codec, WM8961_RIGHT_INPUT_VOLUME);
+ codec->cache_bypass = 0;
dev_info(codec->dev, "WM8961 family %d revision %c\n",
(reg & WM8961_DEVICE_ID_MASK) >> WM8961_DEVICE_ID_SHIFT,
((reg & WM8961_CHIP_REV_MASK) >> WM8961_CHIP_REV_SHIFT)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] ASoC: wm8961: Convert codec->hw_read to snd_soc_read
2011-10-14 1:37 ` [PATCH 3/3] ASoC: wm8991: " Axel Lin
@ 2011-10-14 1:39 ` Axel Lin
2011-10-14 19:36 ` Mark Brown
2011-10-14 1:41 ` [PATCH 3/3] ASoC: wm8991: " Axel Lin
1 sibling, 1 reply; 9+ messages in thread
From: Axel Lin @ 2011-10-14 1:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, alsa-devel
codec->hw_read is broken now, let's covert to snd_soc_read.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/wm8961.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8961.c b/sound/soc/codecs/wm8961.c
index cdee810..9568c8a 100644
--- a/sound/soc/codecs/wm8961.c
+++ b/sound/soc/codecs/wm8961.c
@@ -974,7 +974,9 @@ static int wm8961_probe(struct snd_soc_codec *codec)
}
/* This isn't volatile - readback doesn't correspond to write */
- reg = codec->hw_read(codec, WM8961_RIGHT_INPUT_VOLUME);
+ codec->cache_bypass = 1;
+ reg = snd_soc_read(codec, WM8961_RIGHT_INPUT_VOLUME);
+ codec->cache_bypass = 0;
dev_info(codec->dev, "WM8961 family %d revision %c\n",
(reg & WM8961_DEVICE_ID_MASK) >> WM8961_DEVICE_ID_SHIFT,
((reg & WM8961_CHIP_REV_MASK) >> WM8961_CHIP_REV_SHIFT)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] ASoC: wm8991: Convert codec->hw_read to snd_soc_read
2011-10-14 1:37 ` [PATCH 3/3] ASoC: wm8991: " Axel Lin
2011-10-14 1:39 ` [PATCH 3/3] ASoC: wm8961: " Axel Lin
@ 2011-10-14 1:41 ` Axel Lin
1 sibling, 0 replies; 9+ messages in thread
From: Axel Lin @ 2011-10-14 1:41 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, alsa-devel
2011/10/14 Axel Lin <axel.lin@gmail.com>:
> codec->hw_read is broken now, let's covert to snd_soc_read.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/wm8961.c | 4 +++-
Please ignore this one. the subject line is wrong.
The correct subject line is " [PATCH 3/3] ASoC: wm8961: Convert
codec->hw_read to snd_soc_read"
Axel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to snd_soc_read
2011-10-14 1:35 [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to snd_soc_read Axel Lin
2011-10-14 1:37 ` [PATCH 2/3] ASoC: tlv320aic3x: " Axel Lin
2011-10-14 1:37 ` [PATCH 3/3] ASoC: wm8991: " Axel Lin
@ 2011-10-14 19:34 ` Mark Brown
2 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2011-10-14 19:34 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, linux-kernel, Arnaud Patard, Liam Girdwood
On Fri, Oct 14, 2011 at 09:35:20AM +0800, Axel Lin wrote:
> codec->hw_read is broken now, let's covert to snd_soc_read.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-10-14 19:44 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-14 1:35 [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to snd_soc_read Axel Lin
2011-10-14 1:37 ` [PATCH 2/3] ASoC: tlv320aic3x: " Axel Lin
2011-10-14 19:35 ` Mark Brown
2011-10-14 19:44 ` Vladimir Barinov
2011-10-14 1:37 ` [PATCH 3/3] ASoC: wm8991: " Axel Lin
2011-10-14 1:39 ` [PATCH 3/3] ASoC: wm8961: " Axel Lin
2011-10-14 19:36 ` Mark Brown
2011-10-14 1:41 ` [PATCH 3/3] ASoC: wm8991: " Axel Lin
2011-10-14 19:34 ` [PATCH 1/3] ASoC: alc5623: " Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).