From: Daniel Mack <zonque@gmail.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: tiwai@suse.de, blablack@gmail.com, alsa-devel@alsa-project.org,
gdiffey@gmail.com, linuxaudio@showlabor.de
Subject: Re: [PATCH 1/5] ALSA: snd-usb: implement new endpoint streaming model
Date: Wed, 02 Nov 2011 15:29:19 +0100 [thread overview]
Message-ID: <4EB153BF.2090204@gmail.com> (raw)
In-Reply-To: <4EB11ADD.2090701@ladisch.de>
On 11/02/2011 11:26 AM, Clemens Ladisch wrote:
> Daniel Mack wrote:
>> +void snd_usb_handle_sync_urb(struct snd_usb_endpoint *ep,
>> +{
>> + if (snd_usb_endpoint_implict_feedback_sink(ep)&& ep->use_count> 0) {
>> ...
>> + for (i = 0; i< ep->nurbs; i++)
>> + if (!test_and_set_bit(i,&ep->active_mask)) {
>> + out_urb = ep->urb[i].urb;
>> + break;
>> + }
>> +
>> + if (!out_urb) {
>> + snd_printk(KERN_ERR "Unable to find an urb for playback (nurbs %d)\n",
>> + ep->nurbs);
>
> AFAICS the driver tries for all URBS to be queued at all times.
Hmm, no, not for the "implicit feedback" case. In this mode, we don't
queue any output urbs on startup but wait for the capture urbs to arrive
and then queue from there. So this should be ok, right?
Daniel
next prev parent reply other threads:[~2011-11-02 14:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 12:10 [PATCH 0/5] RFC for snd-usb: rework usb endpoint logic Daniel Mack
2011-10-31 12:10 ` [PATCH 1/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
2011-11-01 20:57 ` Clemens Ladisch
2011-11-02 8:36 ` Daniel Mack
2011-11-02 10:26 ` Clemens Ladisch
2011-11-02 14:29 ` Daniel Mack [this message]
2011-11-02 15:49 ` Clemens Ladisch
2011-11-03 15:21 ` Daniel Mack
2011-11-03 16:42 ` Clemens Ladisch
2011-10-31 12:10 ` [PATCH 2/5] ALSA: snd-usb: switch over to new endpoint streaming logic Daniel Mack
2011-11-01 20:57 ` Clemens Ladisch
2011-11-02 15:58 ` Takashi Iwai
2011-11-02 16:18 ` Clemens Ladisch
2011-11-02 16:18 ` Takashi Iwai
2011-11-02 22:01 ` Torsten Schenk
2011-11-18 14:44 ` Daniel Mack
2011-11-18 14:41 ` Daniel Mack
2011-10-31 12:10 ` [PATCH 3/5] ALSA: snd-usb: remove old " Daniel Mack
2011-10-31 12:10 ` [PATCH 4/5] ALSA: snd-usb: set MAX_URBS to 16 Daniel Mack
2011-11-01 20:57 ` Clemens Ladisch
2011-10-31 12:10 ` [PATCH 5/5] ALSA: snd-usb: add support for implicit feedback Daniel Mack
2011-10-31 12:38 ` [PATCH 0/5] RFC for snd-usb: rework usb endpoint logic Daniel Mack
2011-11-01 8:50 ` Aurélien Leblond
2011-11-01 9:15 ` Daniel Mack
2011-11-01 9:40 ` Felix Homann
2011-11-01 10:25 ` Daniel Mack
2011-11-01 10:39 ` Felix Homann
2011-11-01 12:11 ` Daniel Mack
2011-11-01 13:59 ` Grant Diffey
2011-11-01 15:36 ` Takashi Iwai
2011-11-01 16:19 ` Takashi Iwai
2011-11-01 19:03 ` Felix Homann
2011-11-02 6:49 ` Takashi Iwai
2011-11-02 8:27 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB153BF.2090204@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=blablack@gmail.com \
--cc=clemens@ladisch.de \
--cc=gdiffey@gmail.com \
--cc=linuxaudio@showlabor.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).