From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH 1/5] ALSA: snd-usb: implement new endpoint
 streaming model
Date: Wed, 02 Nov 2011 15:29:19 +0100
Message-ID: <4EB153BF.2090204@gmail.com>
References: <1320063030-3502-1-git-send-email-zonque@gmail.com>
	<1320063030-3502-2-git-send-email-zonque@gmail.com>
	<4EB11ADD.2090701@ladisch.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mail-fx0-f51.google.com (mail-fx0-f51.google.com
	[209.85.161.51]) by alsa0.perex.cz (Postfix) with ESMTP id 063BB2446A
	for <alsa-devel@alsa-project.org>; Wed,  2 Nov 2011 15:29:32 +0100 (CET)
Received: by faao24 with SMTP id o24so502441faa.38
	for <alsa-devel@alsa-project.org>; Wed, 02 Nov 2011 07:29:31 -0700 (PDT)
In-Reply-To: <4EB11ADD.2090701@ladisch.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Clemens Ladisch <clemens@ladisch.de>
Cc: tiwai@suse.de, blablack@gmail.com, alsa-devel@alsa-project.org, gdiffey@gmail.com, linuxaudio@showlabor.de
List-Id: alsa-devel@alsa-project.org

On 11/02/2011 11:26 AM, Clemens Ladisch wrote:
> Daniel Mack wrote:
>> +void snd_usb_handle_sync_urb(struct snd_usb_endpoint *ep,
>> +{
>> +	if (snd_usb_endpoint_implict_feedback_sink(ep)&&  ep->use_count>  0) {
>>   		...
>> +		for (i = 0; i<  ep->nurbs; i++)
>> +			if (!test_and_set_bit(i,&ep->active_mask)) {
>> +				out_urb = ep->urb[i].urb;
>> +				break;
>> +			}
>> +
>> +		if (!out_urb) {
>> +			snd_printk(KERN_ERR "Unable to find an urb for playback (nurbs %d)\n",
>> +				   ep->nurbs);
>
> AFAICS the driver tries for all URBS to be queued at all times.

Hmm, no, not for the "implicit feedback" case. In this mode, we don't 
queue any output urbs on startup but wait for the capture urbs to arrive 
and then queue from there. So this should be ok, right?


Daniel