Re: [PATCH] ASoC: mpc8610: tell the CS4270 codec that it's the master

[Tabi Timur-B04825 <B04825@freescale.com>]

Mark Brown wrote:
> On Tue, Nov 22, 2011 at 02:38:59PM -0600, Timur Tabi wrote:
>> Commit ac601555 ("ASoC: Return early with -EINVAL if invalid dai format is
>> detected") requires the machine driver to tell the CS4270 codec driver
>> whether the CS4270 should be configured for master or slave operation.
>
> Applied, thanks.

So it turns out that the commit message for this patch is wrong.  Sorry.

The commit that broke the MPC8610 is "ASoC: Allow DAI formats to be 
specified in the dai_link", which changed the definition of 
SND_SOC_DAIFMT_CBM_CFM to a non-zero value.  Patch "ASoC: Return early 
with -EINVAL if invalid dai format is detected" doesn't really do anything.

I don't know if it's too late to amend the commit, but if it isn't, the 
proper message is:

Commit 4eae080d ("ASoC: Add cs4270 support for slave mode configurations") 
requires the machine driver to set one of the SND_SOC_DAIFMT_CBx_xxx 
values.  The MPC8610 machine driver should be setting 
SND_SOC_DAIFMT_CBM_CFM, but since that value is zero, no one noticed.

Commit 75d9ac46 ("ASoC: Allow DAI formats to be specified in the 
dai_link"), however, changed the value of SND_SOC_DAIFMT_CBM_CFM from zero 
to a non-zero value, which means that it now needs to be specifically set 
by the machine driver.

-- 
Timur Tabi
Linux kernel developer at Freescale