From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 1/5] ASoC: Hold runtime PM references to components of active DAIs
Date: Mon, 05 Dec 2011 16:53:00 +0200 [thread overview]
Message-ID: <4EDCDACC.1040409@ti.com> (raw)
In-Reply-To: <20111205134610.GO11150@opensource.wolfsonmicro.com>
On 12/05/2011 03:46 PM, Mark Brown wrote:
> Well, the pcm_mutex doesn't cover all of those anyway (trigger and
> pointer in particular) and we've no guarantee that anything will
> actually happen at the point where the core does the calls as there may
> be other things holding the device active.
It covers the soc_pcm_open, and soc_pcm_close sequences.
> I don't understand how this could make the situation any worse than it
> is already - if nothing else this series will only make the region where
> we've got the device active slightly wider.
The ordering of the pm_runtime_get/put will be different.
We will have the pm_runtime_put after all other parts of the audio
system has been closed, turned off.
> There's definitely an issue
> there, but it seems like it already exists and is orthogonal to this
> refactoring. The McPDM needs to hold a reference on the CODEC somehow
> while it is active it seems, either via DAPM or via the runtime_pm APIs.
Yes, this is the reason we do not have the BIAS_OFF support in twl6040
still. I'm working on to integrate the external fclk (bit clock from
twl6040) for McPDM with pm_runtime so we are not going to have issues
with missing clocks.
But as I said at this time we do not have issues since the fclk for
McPDM is always present.
This change actually gives more incentive to do the pm_runtime support
for the McPDM external fclk ;)
--
Péter
next prev parent reply other threads:[~2011-12-05 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 0:01 [PATCH 1/5] ASoC: Hold runtime PM references to components of active DAIs Mark Brown
2011-12-05 0:01 ` [PATCH 2/5] ASoC: Use core pm_runtime callbacks for omap-dmic Mark Brown
2011-12-05 8:02 ` Peter Ujfalusi
2011-12-05 0:01 ` [PATCH 3/5] ASoC: Use core pm_runtime callbacks for omap-mcpdm Mark Brown
2011-12-05 8:32 ` Peter Ujfalusi
2011-12-05 0:01 ` [PATCH 4/5] ASoC: Use core pm_runtime callbacks for siu_dai Mark Brown
2011-12-05 0:01 ` [PATCH 5/5] ASoC: Use core pm_runtime callbacks for fsi Mark Brown
2011-12-05 8:01 ` [PATCH 1/5] ASoC: Hold runtime PM references to components of active DAIs Peter Ujfalusi
2011-12-05 11:39 ` Mark Brown
2011-12-05 13:32 ` Peter Ujfalusi
2011-12-05 13:46 ` Mark Brown
2011-12-05 14:53 ` Peter Ujfalusi [this message]
2011-12-05 15:07 ` Mark Brown
2011-12-07 7:47 ` Peter Ujfalusi
2011-12-07 7:48 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDCDACC.1040409@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).