From: Pavel Hofman <pavel.hofman@ivitera.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH - ice1724 1/4] ALSA: ice1724 - Create capture pcm only for ADC-enabled configurations
Date: Mon, 09 Jan 2012 10:48:11 +0100 [thread overview]
Message-ID: <4F0AB7DB.2010407@ivitera.com> (raw)
In-Reply-To: <s5hmx9xkyz6.wl%tiwai@suse.de>
Dne 9.1.2012 10:27, Takashi Iwai napsal(a):
> At Mon, 09 Jan 2012 08:36:54 +0100,
> Pavel Hofman wrote:
>>
>>
>
> Ah, then I misunderstood your code. The bit-wise operation is
> confusing for such a case.
>
> It should be rather more easy-readable like:
>
> if ((ice->eeprom.data[ICE_EEP2_SYSCONF] & VT1724_CFG_ADC_MASK) ==
> VT1724_CFG_ADC_NONE)
> capt = 0;
> else
> capt = 1;
>
> Could you revise the patch?
>
Absolutely, happy to do so. Just please is there a way for me to
"migrate" from git.alsa-project.org to your repozitory at kernel.org
where the other patches were committed? I mean without compiling the
whole kernel, just the drivers as with alsa-project.org? I followed the
description at
http://alsa-project.org/main/index.php/GIT_Server#Occasional_Developers
. The kmirror at git.alsa-project.org seems to be a bit behind.
Thanks a lot for help,
Pavel.
next prev parent reply other threads:[~2012-01-09 9:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 21:01 [PATCH - ice1724 1/4] ALSA: ice1724 - Create capture pcm only for ADC-enabled configurations pavel.hofman
2012-01-05 21:01 ` [PATCH - ice1724 2/4] ALSA: ice1724 - External clock item only for cards with SPDIF_IN pavel.hofman
2012-01-08 13:33 ` Takashi Iwai
2012-01-05 21:01 ` [PATCH - ice1724 3/4] ALSA: ice1724 - Allow card info based on model only pavel.hofman
2012-01-08 13:33 ` Takashi Iwai
2012-01-05 21:01 ` [PATCH - ice1724 4/4] ALSA: ice1724 - Support for ooAoo SQ210a pavel.hofman
2012-01-08 9:13 ` Takashi Iwai
2012-01-09 8:32 ` Pavel Hofman
2012-01-09 9:24 ` Clemens Ladisch
2012-01-09 9:59 ` Pavel Hofman
2012-01-08 9:12 ` [PATCH - ice1724 1/4] ALSA: ice1724 - Create capture pcm only for ADC-enabled configurations Takashi Iwai
2012-01-09 7:36 ` Pavel Hofman
2012-01-09 9:27 ` Takashi Iwai
2012-01-09 9:48 ` Pavel Hofman [this message]
2012-01-09 9:51 ` Takashi Iwai
2012-01-09 9:53 ` Pavel Hofman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0AB7DB.2010407@ivitera.com \
--to=pavel.hofman@ivitera.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).