From: "Jérémy Lal" <kapouer@melix.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: imac27 12,2 (2011) model for patch_cirrus.c
Date: Mon, 09 Jan 2012 14:53:10 +0100 [thread overview]
Message-ID: <4F0AF146.9030000@melix.org> (raw)
In-Reply-To: <s5haa5xkvuw.wl%tiwai@suse.de>
On 09/01/2012 11:34, Takashi Iwai wrote:
> At Thu, 29 Dec 2011 13:00:01 +0100,
> Jérémy Lal wrote:
>>
>> Hi,
>> it'd be glad to have patch_cirrus.c recognize model=imac27_122,
>> (i'm adding a model because it's harder to auto-detect it),
>> please find attached patch, tested on linux 3.2-rc7.
>> I don't know anything about pin configs, just that it works with
>> the ones in the patch.
>> Note that i tried with model=auto (no sound) and model=imac27 (front speakers
>> not muted when headphones are plugged in, and surround speakers not properly
>> detected).
>
> Thanks for the patch. But I see a problem in the code, i.e.
>
>> +static const struct cs_pincfg imac27_122_pincfgs[] = {
>> + { 0x00, 0x821c9700 },
>> + { 0x01, 0x011d9700 },
> (snip)
>> + { 0x27, 0x401f5701 },
>> + {} /* terminator */
>> +};
>
> This looks obviously wrong. The pincfg table should contain only the
> default pin-configuration values for pin widgets while you are setting
> some values to all widgets. Please minimize this entry.
It's working without overriding pin-configurations :)
I tested almost everything except digital input/output.
A kernel with the following patch and
options snd-hda-intel model=imac27_122
is enough to get sound working.
--- linux-source-3.2-rc7.orig/sound/pci/hda/patch_cirrus.c 2011-12-24 06:51:06.000000000 +0100
+++ linux-source-3.2-rc7/sound/pci/hda/patch_cirrus.c 2012-01-09 12:40:53.026430475 +0100
@@ -78,6 +78,7 @@
CS420X_MBP53,
CS420X_MBP55,
CS420X_IMAC27,
+ CS420X_IMAC27_122,
CS420X_APPLE,
CS420X_AUTO,
CS420X_MODELS
@@ -1278,6 +1279,7 @@
[CS420X_MBP53] = "mbp53",
[CS420X_MBP55] = "mbp55",
[CS420X_IMAC27] = "imac27",
+ [CS420X_IMAC27_122] = "imac27_122",
[CS420X_APPLE] = "apple",
[CS420X_AUTO] = "auto",
};
@@ -1392,6 +1394,12 @@
spec->gpio_eapd_speaker = 8; /* GPIO3 = speakers */
spec->gpio_mask = spec->gpio_dir =
spec->gpio_eapd_hp | spec->gpio_eapd_speaker;
+ break;
+ case CS420X_IMAC27_122:
+ spec->gpio_eapd_hp = 4; /* GPIO2 = headphones */
+ spec->gpio_eapd_speaker = 8; /* GPIO3 = speakers */
+ spec->gpio_mask = spec->gpio_dir =
+ spec->gpio_eapd_hp | spec->gpio_eapd_speaker;
break;
}
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2012-01-09 13:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 12:00 imac27 12,2 (2011) model for patch_cirrus.c Jérémy Lal
2012-01-09 10:34 ` Takashi Iwai
2012-01-09 13:53 ` Jérémy Lal [this message]
2012-01-09 13:58 ` Takashi Iwai
2012-01-09 14:26 ` Jérémy Lal
2012-01-09 14:29 ` Takashi Iwai
2012-01-09 15:18 ` Jérémy Lal
2012-01-09 15:43 ` Takashi Iwai
2012-01-09 16:19 ` Jérémy Lal
2012-01-09 16:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0AF146.9030000@melix.org \
--to=kapouer@melix.org \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).