From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH v5] ASoC: Apply msbits constraint for sample size bigger than the msbits
Date: Wed, 18 Jan 2012 16:49:36 +0100 [thread overview]
Message-ID: <4F16EA10.6080306@ti.com> (raw)
In-Reply-To: <4F16E8A8.9070209@ti.com>
On 01/18/2012 04:43 PM, Peter Ujfalusi wrote:
> On 01/18/2012 04:35 PM, Clemens Ladisch wrote:
>> Peter Ujfalusi wrote:
>>> We run the loop as long as the sample size is bigger than the requested
>>> msbits.
>>
>>> + while (sample_sizes[i] > bits && i < ARRAY_SIZE(sample_sizes)) {
>>
>> This will overrun sample_sizes[] if bits < 8.
>
> which is prevented by the: && i < ARRAY_SIZE(sample_sizes)
I take it back. True, we overrun. These need to be swapped.
--
Péter
prev parent reply other threads:[~2012-01-18 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 15:05 [PATCH v5] ASoC: Apply msbits constraint for sample size bigger than the msbits Peter Ujfalusi
2012-01-18 15:29 ` Mark Brown
2012-01-18 16:43 ` Peter Ujfalusi
2012-01-18 17:46 ` Mark Brown
2012-01-19 8:27 ` Peter Ujfalusi
2012-01-19 10:48 ` Mark Brown
2012-01-19 12:40 ` Peter Ujfalusi
2012-01-19 15:39 ` Mark Brown
2012-01-18 15:35 ` Clemens Ladisch
2012-01-18 15:43 ` Peter Ujfalusi
2012-01-18 15:49 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F16EA10.6080306@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=clemens@ladisch.de \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).