From: Lars-Peter Clausen <lars@metafoo.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: add driver for max9768 amplifier
Date: Wed, 18 Jan 2012 20:40:17 +0100 [thread overview]
Message-ID: <4F172021.7020501@metafoo.de> (raw)
In-Reply-To: <20120118192625.GA13708@pengutronix.de>
On 01/18/2012 08:26 PM, Wolfram Sang wrote:
>>> + ret = snd_soc_cache_write(codec, reg, value);
>>> + if (ret < 0)
>>> + return ret;
>>> +
>>> + data = (reg << 6) | value;
>>
>>
>> Adding support for this register type to regmap and use regmap then is the
>> way to go. regmap should also be used for the cache instead of the legacy
>> ASoC cache.
>
> Okay, are you already at it? Otherwise I'll try adding this tomorrow.
I won't have time for it before the weekend, so go ahead.
next prev parent reply other threads:[~2012-01-18 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 15:38 [PATCH] ASoC: add driver for max9768 amplifier Wolfram Sang
2012-01-18 17:24 ` Lars-Peter Clausen
2012-01-18 19:26 ` Wolfram Sang
2012-01-18 19:40 ` Lars-Peter Clausen [this message]
2012-01-18 17:53 ` Mark Brown
2012-01-18 19:33 ` Wolfram Sang
2012-01-19 10:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F172021.7020501@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).