alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Javier Martin <javier.martin@vista-silicon.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: Add external amplifier controls for Visstrim_M10.
Date: Thu, 19 Jan 2012 17:52:38 +0100	[thread overview]
Message-ID: <4F184A56.3080007@metafoo.de> (raw)
In-Reply-To: <1326984807-10424-1-git-send-email-javier.martin@vista-silicon.com>

On 01/19/2012 03:53 PM, Javier Martin wrote:
> Visstrim_M10 has an external class D amplifier.
> This patch provides support for controlling the 4
> possible gain levels and per channel muting.
> 
> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
> ---
>  sound/soc/imx/mx27vis-aic32x4.c |   72 +++++++++++++++++++++++++++++++++++++++
>  1 files changed, 72 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/imx/mx27vis-aic32x4.c b/sound/soc/imx/mx27vis-aic32x4.c
> index d37e23c..47a7bf9 100644
> --- a/sound/soc/imx/mx27vis-aic32x4.c
> +++ b/sound/soc/imx/mx27vis-aic32x4.c
> @@ -25,16 +25,36 @@
> [...]
> +
>  static const struct snd_kcontrol_new mx27vis_aic32x4_controls[] = {
>  	SOC_DAPM_PIN_SWITCH("External Mic"),
> +	SOC_SINGLE_EXT("LO Ext Boost", MX27VIS_AMP_GAIN, 0, 3, 0,
> +		       mx27vis_amp_get, mx27vis_amp_set),

Do you know the dB gain of the amplifier? If yes you should provide it using
SOC_SINGLE_EXT_TLV.

> [...]
>  };
>  
> [...]

      parent reply	other threads:[~2012-01-19 16:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 14:53 [PATCH] ASoC: Add external amplifier controls for Visstrim_M10 Javier Martin
2012-01-19 15:45 ` Mark Brown
2012-01-19 16:37   ` javier Martin
2012-01-19 17:59     ` Mark Brown
2012-01-19 16:52 ` Lars-Peter Clausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F184A56.3080007@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=javier.martin@vista-silicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).