alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Joerg-Cyril.Hoehle@t-systems.com
Cc: alsa-devel@alsa-project.org
Subject: Re: Improve hw_params documentation -- details of constraint resolution
Date: Fri, 20 Jan 2012 14:41:23 +0100	[thread overview]
Message-ID: <4F196F03.8080002@ladisch.de> (raw)
In-Reply-To: <8E4C156DA5797D418DBFADFD8CE655A41782ACA717@HE113481.emea1.cds.t-internal.com>

Joerg-Cyril.Hoehle@t-systems.com wrote:
> + *  When a parameter is set or restricted using a snd_pcm_hw_params_set*
> + *  function, all of the other ranges will be updated to exclude as many
> + *  impossible configurations as possible. Attempting to set a parameter
> + *  outside of its acceptable range will result in the function failing
> + *  and an error code being returned.
>
> I'd like to check whether that's exactly what's happening.
>
> 1. Consider the following scenario:
>
> set_hw_params_period_near([in,out]10ms,[out]dir)
> yields 16ms and direction=0 <=> "exact match"
>
> set_hw_params_buffer_size(X)
> set_hw_params()
>
> So far, I thought that if ALSA replied with direction=0, then that
> corner stone of the configuration space was fixed.

This has nothing to do with the dir parameter.

The period_time parameter is fixed when the set(_near) function
returns successfully.

The dir parameter tells whether the value is an exact integer,
or if it's smaller or larger (such as 15.9 or 16.667).

> OTOH, if constraint resolutions occurs at the time of set_hw_params()
> *again and finally*,

Indeed this occurs again because not all parameters might have been
reduced to a single value yet.

> ALSA may realize that the particularly large or
> small buffer size X is not reachable with the 16ms period, whereas
> a 50ms or 5ms period may allow buffer size X.
>
> So what is the outcome?
> b) revised 5 or 50ms period with buffer size X,
>    because 5 or 50ms is a near period?

Setting a parameter always happens in the context of the values of
any other parameters that have been set, and all rules and restrictions
implied by that.

Once a parameter has been reduced to a single value (or just to
a smaller interval), it cannot be changed back.

> c) 16ms period, error from set_buffer_size and success from set_hw_params
>    as ALSA chooses an arbitrary buffer size (typically 4-8 periods)?

Yes.

> The documentation may lead one to believe b) happens.

How so?

> 2.
> + *  Attempting to set a parameter
> + *  outside of its acceptable range will result in the function failing
> + *  and an error code being returned.
>
> That does not seem to apply to the set_*_near() functions.
>
> set_hw_params_period_time(2ms) may fail because it's too small for the
> device at hand, whereas set_hw_params_period_time_near(2ms) causes the
> smallest supported period to be chosen.  Does this need clarification
> or is using *_near not "attempting to set a parameter"?

set_*_near() searches for the nearest value in the acceptable range,
which it then attempts to set.

> *_min and *_max appear to behave likewise: they set lower and upper
> bounds without checking whether these are reachable.

They do not 'set' the value, they just restrict the acceptable range;
a limit that is outside the previously acceptable range is not an error
because this does not result in an 'impossible' configuration.
For example, assume that a device supports period times from 10 ms to
100 ms.  Calling set_period_time_min(2ms) means "I accept anything in
the range from 2 ms to infinity", so the resulting period time is the
interval from 10 ms to 100 ms (i.e., unchanged).  This is correct
because all values in this interval indeed are >= 2 ms.

set_period_time_min(2ms) would fail if the maximum period time is
already less than 2 ms, because then there wouldn't be any valid
period time value left.


Regards,
Clemens

      reply	other threads:[~2012-01-20 13:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 10:33 Improve hw_params documentation -- details of constraint resolution Joerg-Cyril.Hoehle
2012-01-20 13:41 ` Clemens Ladisch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F196F03.8080002@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=Joerg-Cyril.Hoehle@t-systems.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).