From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tabi Timur-B04825 Subject: Re: [PATCH 15/20] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX Date: Mon, 5 Mar 2012 12:28:52 +0000 Message-ID: <4F54B183.4080607@freescale.com> References: <1330788001-10158-1-git-send-email-shawn.guo@linaro.org> <1330788001-10158-16-git-send-email-shawn.guo@linaro.org> <4F53F704.8080703@freescale.com> <20120305073930.GC16232@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from tx2outboundpool.messaging.microsoft.com (tx2ehsobe004.messaging.microsoft.com [65.55.88.14]) by alsa0.perex.cz (Postfix) with ESMTP id ECC1F103FDA for ; Mon, 5 Mar 2012 13:29:04 +0100 (CET) In-Reply-To: <20120305073930.GC16232@S2101-09.ap.freescale.net> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Shawn Guo Cc: "alsa-devel@alsa-project.org" , Mark Brown , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org Shawn Guo wrote: > Yeah, it makes the diff neat. However I would make it an inline > function which is easier to play. However you want to do it is fine with me, although I would use "u32 __iomem *addr" instead of "void __iomem *addr". -- Timur Tabi Linux kernel developer at Freescale