From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Vinod Koul <vinod.koul@linux.intel.com>,
Russell King <linux@arm.linux.org.uk>,
Ryan Mallon <rmallon@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mika Westerberg <mika.westerberg@iki.fi>,
alsa-devel@alsa-project.org, Wolfram Sang <w.sang@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>, Liam Girdwood <lrg@ti.com>
Subject: Re: [RFC 4/7] ASoC: Add dmaengine PCM helper functions
Date: Mon, 05 Mar 2012 13:30:42 +0100 [thread overview]
Message-ID: <4F54B1F2.70508@metafoo.de> (raw)
In-Reply-To: <20120302135959.GG3230@opensource.wolfsonmicro.com>
On 03/02/2012 02:59 PM, Mark Brown wrote:
> On Wed, Feb 22, 2012 at 10:49:08AM +0100, Lars-Peter Clausen wrote:
>> This patch adds a set of functions which are intended to be used when
>> implementing a dmaengine based sound PCM driver.
>
> Having this framework is a substantial win and I got bored waiting for
> the repost of this and the subsequent patches (especially given that the
> merge window is drawing nearer). Since the fix for ep93xx is so simple
> and it works on i.MX I went ahead and applied everything except the
> ep93xx conversion. Thanks!
>
> Please resend the ep93xx conversion along with the tweak to the core so
> we can get that working.
I was at trade show for the rest of last week, without much time for
anything else. I will submit the missing patches in a moment.
> It would also be good to update FSI to use this library as it's also
> using dmaengine (the patch having been merged just before this one it
> got missed in the updates I expect).
I've had a look at the FSI dmaengine driver and it is not straight forward
to convert. For one it does not use cyclic dma transfers so it is more
something for Russel's patch and on the other hand the FSI PCM driver
introduces another layer of indirection which is used to be able to switch
between PIO and DMA. But as a result the functions the dmaengine PCM
framework provides don't really fit anymore.
- Lars
next prev parent reply other threads:[~2012-03-05 12:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 9:49 [RFC 0/7] ASoC: Introduce dmaengine pcm helper functions Lars-Peter Clausen
2012-02-22 9:49 ` [RFC 1/7] ASoC: imx-ssi: Set dma data early Lars-Peter Clausen
2012-02-22 13:22 ` Mark Brown
2012-02-22 9:49 ` [RFC 2/7] ASoC: imx-pcm: Request DMA channel early Lars-Peter Clausen
2012-02-22 13:22 ` Mark Brown
2012-02-22 9:49 ` [RFC 3/7] ASoC: mxs-pcm: " Lars-Peter Clausen
2012-02-22 13:22 ` Mark Brown
2012-02-22 9:49 ` [RFC 4/7] ASoC: Add dmaengine PCM helper functions Lars-Peter Clausen
2012-02-22 10:01 ` Russell King - ARM Linux
2012-02-22 12:52 ` Lars-Peter Clausen
2012-02-22 13:00 ` Mark Brown
2012-02-22 13:21 ` Mark Brown
2012-02-22 13:30 ` Vinod Koul
2012-02-22 13:30 ` Mark Brown
2012-02-22 13:32 ` Russell King - ARM Linux
2012-02-22 13:39 ` Mark Brown
2012-02-22 14:22 ` Russell King - ARM Linux
2012-02-22 15:04 ` Mark Brown
2012-02-22 15:23 ` Russell King - ARM Linux
2012-02-22 15:39 ` Mark Brown
2012-02-23 6:57 ` Vinod Koul
2012-03-02 13:59 ` Mark Brown
2012-03-05 12:30 ` Lars-Peter Clausen [this message]
2012-03-05 12:41 ` Mark Brown
2012-03-07 0:38 ` Kuninori Morimoto
2012-03-07 11:42 ` Mark Brown
2012-02-22 9:49 ` [RFC 5/7] ASoC: imx-pcm-dma: Use " Lars-Peter Clausen
2012-02-22 9:49 ` [RFC 6/7] ASoC: mxs-pcm: " Lars-Peter Clausen
2012-02-22 9:49 ` [RFC 7/7] ASoC: ep93xx-pcm: " Lars-Peter Clausen
2012-02-27 8:19 ` Mika Westerberg
2012-02-27 8:51 ` Lars-Peter Clausen
2012-02-27 19:01 ` Mika Westerberg
2012-02-28 8:47 ` Lars-Peter Clausen
2012-02-28 12:52 ` Mark Brown
2012-02-28 14:17 ` Lars-Peter Clausen
2012-02-28 14:30 ` Mark Brown
2012-02-28 19:23 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54B1F2.70508@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=mika.westerberg@iki.fi \
--cc=rmallon@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=vinod.koul@linux.intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).