From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Tony Lindgren <tony@atomide.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] ARM/ASoC: OMAP McBSP: Move remainig defines from arch to ASoC header
Date: Thu, 08 Mar 2012 11:29:36 +0200 [thread overview]
Message-ID: <4F587C00.1090307@ti.com> (raw)
In-Reply-To: <1331198537-13469-3-git-send-email-peter.ujfalusi@ti.com>
Hi Jarkko,
On 03/08/2012 11:22 AM, Peter Ujfalusi wrote:
> Clock signal muxing, and functional clock related defines are only needed
> in ASoC drivers.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
I have added your ack to this patch by accident when I updated the
series. Sorry about that.
Please confirm if you are OK with this change.
Sorry again,
Péter
> ---
> arch/arm/plat-omap/include/plat/mcbsp.h | 12 ------------
> sound/soc/omap/mcbsp.h | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/mcbsp.h b/arch/arm/plat-omap/include/plat/mcbsp.h
> index 8eb9b0e..1881412 100644
> --- a/arch/arm/plat-omap/include/plat/mcbsp.h
> +++ b/arch/arm/plat-omap/include/plat/mcbsp.h
> @@ -31,18 +31,6 @@
> #define MCBSP_CONFIG_TYPE3 0x3
> #define MCBSP_CONFIG_TYPE4 0x4
>
> -/* CLKR signal muxing options */
> -#define CLKR_SRC_CLKR 0
> -#define CLKR_SRC_CLKX 1
> -
> -/* FSR signal muxing options */
> -#define FSR_SRC_FSR 0
> -#define FSR_SRC_FSX 1
> -
> -/* McBSP functional clock sources */
> -#define MCBSP_CLKS_PRCM_SRC 0
> -#define MCBSP_CLKS_PAD_SRC 1
> -
> /* Platform specific configuration */
> struct omap_mcbsp_ops {
> void (*request)(unsigned int);
> diff --git a/sound/soc/omap/mcbsp.h b/sound/soc/omap/mcbsp.h
> index a5518d7..acc9470 100644
> --- a/sound/soc/omap/mcbsp.h
> +++ b/sound/soc/omap/mcbsp.h
> @@ -230,6 +230,18 @@ enum {
> #define XRDYEN BIT(10)
> #define XEMPTYEOFEN BIT(14)
>
> +/* CLKR signal muxing options */
> +#define CLKR_SRC_CLKR 0
> +#define CLKR_SRC_CLKX 1
> +
> +/* FSR signal muxing options */
> +#define FSR_SRC_FSR 0
> +#define FSR_SRC_FSX 1
> +
> +/* McBSP functional clock sources */
> +#define MCBSP_CLKS_PRCM_SRC 0
> +#define MCBSP_CLKS_PAD_SRC 1
> +
> /* we don't do multichannel for now */
> struct omap_mcbsp_reg_cfg {
> u16 spcr2;
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-03-08 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 9:22 [PATCH v2 0/3] ARM/ASoC: OMAP McBSP: Correct CLKR/FSR source selection Peter Ujfalusi
2012-03-08 9:22 ` [PATCH v2 1/3] ARM: OMAP2+: McBSP: Correct CLKR/FSR clock source mux configuration Peter Ujfalusi
2012-03-08 21:12 ` Tony Lindgren
2012-03-08 9:22 ` [PATCH v2 2/3] ARM/ASoC: OMAP McBSP: Move remainig defines from arch to ASoC header Peter Ujfalusi
2012-03-08 9:29 ` Peter Ujfalusi [this message]
2012-03-08 9:37 ` Jarkko Nikula
2012-03-08 10:58 ` Mark Brown
2012-03-08 9:22 ` [PATCH v2 3/3] ASoC: omap-mcbsp: Single function CLKR/FSR source mux configuration Peter Ujfalusi
2012-03-08 10:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F587C00.1090307@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).