From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: cs4270: Check that we can enable regulators on resume
Date: Mon, 19 Mar 2012 12:46:24 -0500 [thread overview]
Message-ID: <4F6770F0.70002@freescale.com> (raw)
In-Reply-To: <1332173777-9786-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Mark Brown wrote:
> It's possible that the regulator enable will fail and if it does we may
> as well just give up with trying to bring the rest of the device up and
> report the original error.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
CC sound/soc/codecs/cs4270.o
/home/b04825/git/alsa.guts/sound/soc/codecs/cs4270.c: In function
'cs4270_soc_resume':
/home/b04825/git/alsa.guts/sound/soc/codecs/cs4270.c:605:2: error: 'ret'
undeclared (first use in this function)
/home/b04825/git/alsa.guts/sound/soc/codecs/cs4270.c:605:2: note: each
undeclared identifier is reported only once for each function it appears in
When I add 'int ret;', it compiles and works. Note, however, that I have
no regular support on this board, so I don't know what I'm really testing.
On a side note, 'reg' should be an 'unsigned int', not an 'int'.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-03-19 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 16:16 [PATCH] ASoC: cs4270: Check that we can enable regulators on resume Mark Brown
2012-03-19 17:46 ` Timur Tabi [this message]
2012-03-19 17:53 ` Mark Brown
2012-03-19 18:37 ` Mark Brown
2012-03-19 18:38 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6770F0.70002@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).