From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] ASoC: cs4270: Check that we can enable regulators on resume Date: Mon, 19 Mar 2012 12:46:24 -0500 Message-ID: <4F6770F0.70002@freescale.com> References: <1332173777-9786-1-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from ch1outboundpool.messaging.microsoft.com (ch1ehsobe002.messaging.microsoft.com [216.32.181.182]) by alsa0.perex.cz (Postfix) with ESMTP id 03139103AFD for ; Mon, 19 Mar 2012 18:46:33 +0100 (CET) In-Reply-To: <1332173777-9786-1-git-send-email-broonie@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org Mark Brown wrote: > It's possible that the regulator enable will fail and if it does we may > as well just give up with trying to bring the rest of the device up and > report the original error. > > Signed-off-by: Mark Brown > --- CC sound/soc/codecs/cs4270.o /home/b04825/git/alsa.guts/sound/soc/codecs/cs4270.c: In function 'cs4270_soc_resume': /home/b04825/git/alsa.guts/sound/soc/codecs/cs4270.c:605:2: error: 'ret' undeclared (first use in this function) /home/b04825/git/alsa.guts/sound/soc/codecs/cs4270.c:605:2: note: each undeclared identifier is reported only once for each function it appears in When I add 'int ret;', it compiles and works. Note, however, that I have no regular support on this board, so I don't know what I'm really testing. On a side note, 'reg' should be an 'unsigned int', not an 'int'. -- Timur Tabi Linux kernel developer at Freescale