From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org, Trent Piepho <tpiepho@gmail.com>,
Grazvydas Ignotas <notasas@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 3/3] ASoC: omap-mcbsp: Add period size protection mode
Date: Wed, 21 Mar 2012 10:21:08 +0200 [thread overview]
Message-ID: <4F698F74.30002@ti.com> (raw)
In-Reply-To: <4F698DAC.7060503@bitmer.com>
On 03/21/2012 10:13 AM, Jarkko Nikula wrote:
> Oh yes. I guess start_threshold is not even known yet when we are ruling
> the buffer size so we cannot use it as a source for alternative rules?
We do place rule for the buffer size, so it is guarantied that it is
bigger than the FIFO.
Start threshold is set by the application, and it is not really
guarantied when the application will set it. It can be runtime changes
as well - being sw_param. In most case overwriting in pcm_prepare phase
might work, but it is not guarantied.
Not sure, but what would be probably useful here is to have a way from
the driver level to let userspace/ALSA know that we should use this and
that start_threshold.
If application does not care ALSA would use this driver provided
information. If application specifies the start_threshold, we should
obey it. In this case the period size would be needed to have the
constraint, but we do not know beforehand what application wants to do.
--
Péter
next prev parent reply other threads:[~2012-03-21 8:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 11:13 [PATCH 0/3] ASoC: omap-mcbsp: Constraint handling changes Peter Ujfalusi
2012-03-20 11:13 ` [PATCH 1/3] ASoC: omap-mcbsp: buffer size constraint only applies to playback stream Peter Ujfalusi
2012-03-20 15:26 ` Mark Brown
2012-03-20 16:34 ` Jarkko Nikula
2012-03-20 11:13 ` [PATCH 2/3] ASoC: omap-mcbsp: Restructure omap_mcbsp_dai_startup code Peter Ujfalusi
2012-03-20 15:27 ` Mark Brown
2012-03-20 11:13 ` [PATCH 3/3] ASoC: omap-mcbsp: Add period size protection mode Peter Ujfalusi
2012-03-20 16:01 ` Mark Brown
2012-03-20 16:15 ` Grazvydas Ignotas
2012-03-20 17:04 ` Mark Brown
2012-03-20 17:27 ` Grazvydas Ignotas
2012-03-20 18:07 ` Trent Piepho
2012-03-20 18:12 ` Mark Brown
2012-03-21 8:23 ` Peter Ujfalusi
2012-03-21 11:55 ` Grazvydas Ignotas
2012-03-20 16:20 ` Jarkko Nikula
2012-03-20 16:42 ` Grazvydas Ignotas
2012-03-20 19:20 ` Jarkko Nikula
2012-03-20 19:47 ` Trent Piepho
2012-03-21 7:57 ` Peter Ujfalusi
2012-03-21 8:13 ` Jarkko Nikula
2012-03-21 8:21 ` Peter Ujfalusi [this message]
2012-03-21 8:03 ` Peter Ujfalusi
2012-03-21 8:32 ` Jarkko Nikula
2012-03-21 8:40 ` Mark Brown
2012-03-21 9:16 ` Peter Ujfalusi
2012-03-21 9:34 ` Jarkko Nikula
2012-03-21 9:46 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F698F74.30002@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jarkko.nikula@bitmer.com \
--cc=lrg@ti.com \
--cc=notasas@gmail.com \
--cc=tpiepho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).