* [PATCH] sound: fix oss/msnd_pinnacle module param type
[not found] <20120328171401.354ddb56727a26fe64b35ddf@canb.auug.org.au>
@ 2012-03-29 1:26 ` Randy Dunlap
2012-03-29 16:00 ` Takashi Iwai
2012-03-29 1:26 ` [PATCH] sound: fix isa/opti9xx " Randy Dunlap
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2012-03-29 1:26 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Takashi Iwai, alsa-devel, linux-next, LKML
From: Randy Dunlap <rdunlap@xenotime.net>
Fix module parameter data type to eliminate build warning.
sound/oss/msnd_pinnacle.c:1727:1: warning: return from incompatible pointer type
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
sound/oss/msnd_pinnacle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20120328.orig/sound/oss/msnd_pinnacle.c
+++ linux-next-20120328/sound/oss/msnd_pinnacle.c
@@ -1631,7 +1631,7 @@ static int ide_irq __initdata = 0;
static int joystick_io __initdata = 0;
/* If we have the digital daugherboard... */
-static int digital __initdata = 0;
+static bool digital __initdata = false;
#endif
static int fifosize __initdata = DEFFIFOSIZE;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] sound: fix isa/opti9xx module param type
[not found] <20120328171401.354ddb56727a26fe64b35ddf@canb.auug.org.au>
2012-03-29 1:26 ` [PATCH] sound: fix oss/msnd_pinnacle module param type Randy Dunlap
@ 2012-03-29 1:26 ` Randy Dunlap
2012-03-29 16:00 ` Takashi Iwai
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2012-03-29 1:26 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Takashi Iwai, alsa-devel, linux-next, LKML
From: Randy Dunlap <rdunlap@xenotime.net>
Fix module parameter data type to eliminate build warnings.
sound/isa/opti9xx/opti92x-ad1848.c:87:1: warning: return from incompatible pointer type
sound/isa/opti9xx/opti92x-ad1848.c:87:1: warning: return from incompatible pointer type
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
sound/isa/opti9xx/opti92x-ad1848.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20120328.orig/sound/isa/opti9xx/opti92x-ad1848.c
+++ linux-next-20120328/sound/isa/opti9xx/opti92x-ad1848.c
@@ -65,7 +65,7 @@ static int index = SNDRV_DEFAULT_IDX1; /
static char *id = SNDRV_DEFAULT_STR1; /* ID for this card */
//static bool enable = SNDRV_DEFAULT_ENABLE1; /* Enable this card */
#ifdef CONFIG_PNP
-static int isapnp = 1; /* Enable ISA PnP detection */
+static bool isapnp = true; /* Enable ISA PnP detection */
#endif
static long port = SNDRV_DEFAULT_PORT1; /* 0x530,0xe80,0xf40,0x604 */
static long mpu_port = SNDRV_DEFAULT_PORT1; /* 0x300,0x310,0x320,0x330 */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sound: fix oss/msnd_pinnacle module param type
2012-03-29 1:26 ` [PATCH] sound: fix oss/msnd_pinnacle module param type Randy Dunlap
@ 2012-03-29 16:00 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2012-03-29 16:00 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, alsa-devel, linux-next, LKML
At Wed, 28 Mar 2012 18:26:13 -0700,
Randy Dunlap wrote:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix module parameter data type to eliminate build warning.
>
> sound/oss/msnd_pinnacle.c:1727:1: warning: return from incompatible pointer type
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Applied now. Thanks.
Takashi
> ---
> sound/oss/msnd_pinnacle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20120328.orig/sound/oss/msnd_pinnacle.c
> +++ linux-next-20120328/sound/oss/msnd_pinnacle.c
> @@ -1631,7 +1631,7 @@ static int ide_irq __initdata = 0;
> static int joystick_io __initdata = 0;
>
> /* If we have the digital daugherboard... */
> -static int digital __initdata = 0;
> +static bool digital __initdata = false;
> #endif
>
> static int fifosize __initdata = DEFFIFOSIZE;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sound: fix isa/opti9xx module param type
2012-03-29 1:26 ` [PATCH] sound: fix isa/opti9xx " Randy Dunlap
@ 2012-03-29 16:00 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2012-03-29 16:00 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML, alsa-devel
At Wed, 28 Mar 2012 18:26:17 -0700,
Randy Dunlap wrote:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix module parameter data type to eliminate build warnings.
>
> sound/isa/opti9xx/opti92x-ad1848.c:87:1: warning: return from incompatible pointer type
> sound/isa/opti9xx/opti92x-ad1848.c:87:1: warning: return from incompatible pointer type
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Applied this one, too.
Takashi
> ---
> sound/isa/opti9xx/opti92x-ad1848.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20120328.orig/sound/isa/opti9xx/opti92x-ad1848.c
> +++ linux-next-20120328/sound/isa/opti9xx/opti92x-ad1848.c
> @@ -65,7 +65,7 @@ static int index = SNDRV_DEFAULT_IDX1; /
> static char *id = SNDRV_DEFAULT_STR1; /* ID for this card */
> //static bool enable = SNDRV_DEFAULT_ENABLE1; /* Enable this card */
> #ifdef CONFIG_PNP
> -static int isapnp = 1; /* Enable ISA PnP detection */
> +static bool isapnp = true; /* Enable ISA PnP detection */
> #endif
> static long port = SNDRV_DEFAULT_PORT1; /* 0x530,0xe80,0xf40,0x604 */
> static long mpu_port = SNDRV_DEFAULT_PORT1; /* 0x300,0x310,0x320,0x330 */
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-29 16:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120328171401.354ddb56727a26fe64b35ddf@canb.auug.org.au>
2012-03-29 1:26 ` [PATCH] sound: fix oss/msnd_pinnacle module param type Randy Dunlap
2012-03-29 16:00 ` Takashi Iwai
2012-03-29 1:26 ` [PATCH] sound: fix isa/opti9xx " Randy Dunlap
2012-03-29 16:00 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).