alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Liam Girdwood <lrg-l0cyMroinI0@public.gmane.org>,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 04/17] ASoC: tegra: add description to a couple Kconfig options
Date: Mon, 02 Apr 2012 10:32:31 -0600	[thread overview]
Message-ID: <4F79D49F.9000000@wwwdotorg.org> (raw)
In-Reply-To: <20120331194848.GG5012-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>

On 03/31/2012 01:48 PM, Mark Brown wrote:
> On Fri, Mar 30, 2012 at 05:07:19PM -0600, Stephen Warren wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> Even though these options are typically only selected by other options,
>> it's still useful to give them a brief description.
> 
> Why do you find these short descriptions useful?  They'll cause Kconfig
> to prompt for them and...

Honestly, the downstream patches for Tegra30 support that I was
cherry-picking had descriptions for the Tegra30 options, so I needed to
resolve the discrepancy

When doing that, I figured why hide those options, even if they're
typically auto-selected? Perhaps some out-of-tree ASoC machine driver
needs those modules built.

Still, I can go either way; do you want me to drop this, and remove the
equivalent descriptions from the Tegra30 patches?

>> -	tristate
>> +	tristate "Tegra I2S driver"
>>  	depends on SND_SOC_TEGRA
>>  	help
>>  	  Say Y or M if you want to add support for codecs attached to the
> 
> ...there's already a description in the long text anyway?

  parent reply	other threads:[~2012-04-02 16:32 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 23:07 [PATCH 00/17] ASoC: tegra: Add Tegra30 support Stephen Warren
2012-03-30 23:07 ` [PATCH 01/17] ASoC: tegra: remove open-coded clk reference counting Stephen Warren
     [not found] ` <1333148852-17806-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-30 23:07   ` [PATCH 02/17] ASoC: tegra: ensure clocks are enabled when touching registers Stephen Warren
     [not found]     ` <1333148852-17806-3-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 19:14       ` Mark Brown
2012-03-30 23:07   ` [PATCH 03/17] ASoC: tegra: remove unnecessary includes Stephen Warren
     [not found]     ` <1333148852-17806-4-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 19:44       ` Mark Brown
2012-03-30 23:07   ` [PATCH 04/17] ASoC: tegra: add description to a couple Kconfig options Stephen Warren
2012-03-31 19:48     ` Mark Brown
     [not found]       ` <20120331194848.GG5012-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-02 16:32         ` Stephen Warren [this message]
     [not found]           ` <4F79D49F.9000000-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-02 16:37             ` Mark Brown
2012-03-30 23:07   ` [PATCH 05/17] ASoC: tegra: fix Kconfig SND_SOC_TEGRA_ALC5632 indentation Stephen Warren
2012-03-31 19:49     ` Mark Brown
2012-03-30 23:07   ` [PATCH 06/17] ASoC: tegra: fix some checkpatch warnings Stephen Warren
     [not found]     ` <1333148852-17806-7-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 19:49       ` Mark Brown
2012-03-30 23:07   ` [PATCH 07/17] ASoC: tegra: introduce separate Kconfig variable for DAS driver Stephen Warren
     [not found]     ` <1333148852-17806-8-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 19:49       ` Mark Brown
2012-03-30 23:07   ` [PATCH 08/17] ASoC: tegra: make Tegra20 drivers depend on Tegra20 support Stephen Warren
2012-03-30 23:07   ` [PATCH 09/17] ASoC: tegra: sort Makefile into common and per-SoC files Stephen Warren
     [not found]     ` <1333148852-17806-10-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 19:50       ` Mark Brown
2012-03-30 23:07   ` [PATCH 11/17] ASoC: tegra: complete Tegra->Tegra20 renaming Stephen Warren
2012-03-30 23:07   ` [PATCH 12/17] ASoC: tegra: utils: add support for Tegra30 devices Stephen Warren
     [not found]     ` <1333148852-17806-13-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 20:20       ` Mark Brown
     [not found]         ` <20120331202015.GN5012-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-01  1:57           ` Stephen Warren
     [not found]             ` <4F77B5F8.8080205-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-01 10:28               ` Mark Brown
     [not found]                 ` <20120401102814.GC3153-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-02 17:44                   ` Stephen Warren
     [not found]                     ` <4F79E584.7080904-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-02 21:30                       ` Mark Brown
2012-03-30 23:07   ` [PATCH 13/17] ASoC: tegra: set a sensible initial clock rate Stephen Warren
     [not found]     ` <1333148852-17806-14-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 20:17       ` Mark Brown
     [not found]         ` <20120331201754.GM5012-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-01  2:07           ` Stephen Warren
2012-04-01 10:36             ` Mark Brown
2012-03-30 23:07   ` [PATCH 14/17] ASoC: tegra: add tegra30-ahub driver Stephen Warren
     [not found]     ` <1333148852-17806-15-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 20:14       ` Mark Brown
     [not found]         ` <20120331201433.GL5012-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-01  2:04           ` Stephen Warren
     [not found]             ` <4F77B7CA.3020803-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-01 10:31               ` Mark Brown
     [not found]                 ` <20120401103117.GD3153-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-02 17:27                   ` Stephen Warren
     [not found]                     ` <4F79E198.1080606-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-02 22:04                       ` Mark Brown
2012-03-30 23:07   ` [PATCH 15/17] ASoC: tegra: add tegra30-i2s driver Stephen Warren
     [not found]     ` <1333148852-17806-16-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-31 21:34       ` Mark Brown
2012-04-01  2:17         ` Stephen Warren
     [not found]           ` <4F77BAA6.7060304-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-01 10:25             ` Mark Brown
2012-03-30 23:07   ` [PATCH 16/17] ASoC: tegra: add Kconfig and Makefile support for Tegra30 Stephen Warren
2012-03-30 23:07   ` [PATCH 17/17] ASoC: tegra+wm8903 machine: support Tegra30 Stephen Warren
2012-03-31 19:44   ` [PATCH 00/17] ASoC: tegra: Add Tegra30 support Mark Brown
     [not found]     ` <20120331194429.GE5012-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-04-02 16:03       ` Stephen Warren
     [not found]         ` <4F79CDE6.6030501-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-02 16:06           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F79D49F.9000000@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lrg-l0cyMroinI0@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).