* Re: ALSA: hda - Fix internal mic for Lenovo Ideapad U300s
@ 2012-04-10 8:37 Dan Carpenter
2012-04-10 9:47 ` David Henningsson
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-04-10 8:37 UTC (permalink / raw)
To: david.henningsson; +Cc: alsa-devel
Hello David Henningsson,
This is a semi-automatic email about new static checker warnings.
The patch 18dcd3044e4c: "ALSA: hda - Fix internal mic for Lenovo
Ideapad U300s" from Apr 2, 2012, leads to the following Smatch
complaint:
sound/pci/hda/patch_conexant.c:4449 apply_fixup()
error: we previously assumed 'quirk' could be null (see line 4444)
sound/pci/hda/patch_conexant.c
4443 quirk = snd_pci_quirk_lookup(codec->bus->pci, quirk);
4444 if (quirk && table[quirk->value]) {
^^^^^
Old check.
4445 snd_printdd(KERN_INFO "hda_codec: applying pincfg for %s\n",
4446 quirk->name);
4447 apply_pincfg(codec, table[quirk->value]);
4448 }
4449 if (quirk->value == CXT_FIXUP_STEREO_DMIC) {
^^^^^^^^^^^^
New unchecked dereference.
4450 snd_printdd(KERN_INFO "hda_codec: applying internal mic workaround for %s\n",
4451 quirk->name);
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: ALSA: hda - Fix internal mic for Lenovo Ideapad U300s
2012-04-10 8:37 ALSA: hda - Fix internal mic for Lenovo Ideapad U300s Dan Carpenter
@ 2012-04-10 9:47 ` David Henningsson
0 siblings, 0 replies; 2+ messages in thread
From: David Henningsson @ 2012-04-10 9:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: alsa-devel
On 04/10/2012 10:37 AM, Dan Carpenter wrote:
> Hello David Henningsson,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 18dcd3044e4c: "ALSA: hda - Fix internal mic for Lenovo
> Ideapad U300s" from Apr 2, 2012, leads to the following Smatch
> complaint:
>
> sound/pci/hda/patch_conexant.c:4449 apply_fixup()
> error: we previously assumed 'quirk' could be null (see line 4444)
Thanks for spotting - will provide patch shortly.
>
> sound/pci/hda/patch_conexant.c
> 4443 quirk = snd_pci_quirk_lookup(codec->bus->pci, quirk);
> 4444 if (quirk&& table[quirk->value]) {
> ^^^^^
> Old check.
>
> 4445 snd_printdd(KERN_INFO "hda_codec: applying pincfg for %s\n",
> 4446 quirk->name);
> 4447 apply_pincfg(codec, table[quirk->value]);
> 4448 }
> 4449 if (quirk->value == CXT_FIXUP_STEREO_DMIC) {
> ^^^^^^^^^^^^
> New unchecked dereference.
>
> 4450 snd_printdd(KERN_INFO "hda_codec: applying internal mic workaround for %s\n",
> 4451 quirk->name);
>
> regards,
> dan carpenter
>
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-10 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-10 8:37 ALSA: hda - Fix internal mic for Lenovo Ideapad U300s Dan Carpenter
2012-04-10 9:47 ` David Henningsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).