From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: dapm_widget_power_read_file() symmetry issue?
Date: Mon, 04 Jun 2012 16:39:57 -0600 [thread overview]
Message-ID: <4FCD393D.3040205@wwwdotorg.org> (raw)
In dapm_widget_power_read_file(), there is first:
> list_for_each_entry(p, &w->sources, list_sink) {
> if (p->connected && !p->connected(w, p->sink))
> continue;
then right after that:
> list_for_each_entry(p, &w->sinks, list_source) {
> if (p->connected && !p->connected(w, p->sink))
> continue;
Should that last call to p->connected() be p->connected(p->source, w),
since the function's parameters are (source, sink)?
next reply other threads:[~2012-06-04 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 22:39 Stephen Warren [this message]
2012-06-05 16:46 ` dapm_widget_power_read_file() symmetry issue? Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCD393D.3040205@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox