From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] pcm: support for audio wallclock
Date: Fri, 15 Jun 2012 05:13:55 -0500 [thread overview]
Message-ID: <4FDB0AE3.5030809@linux.intel.com> (raw)
In-Reply-To: <s5hehpiqqui.wl%tiwai@suse.de>
> You need to provide a function to indicate whether htstamp_wallclk is
> available or not. Since the function returning tstamp_wallclk is a
> void function and it itself can't return the error, user can't know
> whether it's a bogus value or not.
Yes, this was planned but I wasn't sure how to go about it. These types
of routines usually rely on hw_params, I guess I could query them and
check the .info field. Not sure if there's another way.
Also maybe I should change the return type to provide -EINVAL is somehow
the audio timestamp is not available for a specific device (digital
input as Clemens mentioned)
> And that function should check whether the running PCM protocol
> version is high enough to support the new ABI.
Yep
\
>> +#ifndef DOXYGEN
>> +void INTERNAL(snd_pcm_status_get_htstamp_wallclk)(const snd_pcm_status_t *obj, snd_htimestamp_t *ptr)
>> +#else
>> +void snd_pcm_status_get_htstamp_wallclk(const snd_pcm_status_t *obj, snd_htimestamp_t *ptr)
>> +#endif
>
> I think you can avoid this hack for the new functions.
Ok, I have no idea what I am doing here, just copy-pasted to make it work...
next prev parent reply other threads:[~2012-06-15 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 20:27 [PATCH] pcm: support for audio wallclock Pierre-Louis Bossart
2012-06-14 7:45 ` Takashi Iwai
2012-06-15 10:13 ` Pierre-Louis Bossart [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-28 21:13 Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDB0AE3.5030809@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox