Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Huacai Chen <chenhuacai@gmail.com>
Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org,
	Zhangjin Wu <wuzhangjin@gmail.com>, Hua Yan <yanh@lemote.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Fuxin Zhang <zhangfx@lemote.com>, Huacai Chen <chenhc@lemote.com>,
	Hongliang Tao <taohl@lemote.com>
Subject: Re: [PATCH V2 13/16] ALSA: HDA: Make hda sound card usable for Loongson.
Date: Tue, 19 Jun 2012 11:09:41 +0200	[thread overview]
Message-ID: <4FE041D5.8030002@ladisch.de> (raw)
In-Reply-To: <1340088624-25550-14-git-send-email-chenhc@lemote.com>

Huacai Chen wrote:
> 1, Use 32-bit DMA as a workaround (Loongson has a hardware bug that it
>    doesn't support DMA address above 4GB).
> 2, Modify patch_conexant.c to add Lemote specific code.

Please create separate patches for these two changes.

> +++ b/include/linux/pci_ids.h
> @@ -2906,3 +2906,5 @@
>  #define PCI_DEVICE_ID_XEN_PLATFORM	0x0001
>
>  #define PCI_VENDOR_ID_OCZ		0x1b85
> +
> +#define PCI_VENDOR_ID_LEMOTE		0x1c06

AFAICS this symbol is not used in this patch.

> +#ifdef CONFIG_CPU_LOONGSON3
> +	/* Workaround: Loongson 3 doesn't support 64-bit DMA */
> +	gcap &= ~ICH6_GCAP_64OK;
> +#endif

	/* Workaround: Loongson 3 doesn't actually support 64-bit DMA */


Regards,
Clemens

  reply	other threads:[~2012-06-19  9:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1340088624-25550-1-git-send-email-chenhc@lemote.com>
2012-06-19  6:50 ` [PATCH V2 13/16] ALSA: HDA: Make hda sound card usable for Loongson Huacai Chen
2012-06-19  9:09   ` Clemens Ladisch [this message]
2012-06-19  9:26   ` [alsa-devel] " Takashi Iwai
2012-06-19 10:47     ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE041D5.8030002@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=chenhc@lemote.com \
    --cc=chenhuacai@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=taohl@lemote.com \
    --cc=wuzhangjin@gmail.com \
    --cc=yanh@lemote.com \
    --cc=zhangfx@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox