From: David Henningsson <david.henningsson@canonical.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg)
Date: Thu, 21 Jun 2012 16:50:50 +0200 [thread overview]
Message-ID: <4FE334CA.7090205@canonical.com> (raw)
In-Reply-To: <20120621104743.GT4037@opensource.wolfsonmicro.com>
On 06/21/2012 12:47 PM, Mark Brown wrote:
> On Thu, Jun 21, 2012 at 06:29:40PM +0800, Scott Jiang wrote:
>> 2012/6/21 Mark Brown<broonie@opensource.wolfsonmicro.com>:
>>> On Thu, Jun 21, 2012 at 01:51:58PM -0400, Scott Jiang wrote:
>>>> Signed-off-by: Scott Jiang<scott.jiang.linux@gmail.com>
>
>>> Applied, but as I said last time you should use subject lines that match
>>> up with the rest of the subsystem.
>
>> Sorry, I'm not sure what you mean. Do you mean 80 columns or style?
>> Could you please give me more details?
>
> You're calling the subsystem "asoc" not "ASoC".
While we're at it, how about switching to the a/b/c style used by
several other subsystems?
I personally think "alsa/hda/realtek" looks much prettier than the
shoutier "ALSA: HDA: Realtek:" thing we have today.
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
next prev parent reply other threads:[~2012-06-21 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 17:51 [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg Scott Jiang
2012-06-21 10:08 ` Mark Brown
2012-06-21 10:29 ` Scott Jiang
2012-06-21 10:47 ` Mark Brown
2012-06-21 14:50 ` David Henningsson [this message]
2012-06-21 15:22 ` Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg) Mark Brown
2012-06-21 15:31 ` Takashi Iwai
2012-06-21 15:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE334CA.7090205@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox