Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Eliot Blennerhassett <eliot@blennerhassett.gen.nz>
Subject: Re: [RFC PATCH] Inverted internal mic
Date: Fri, 22 Jun 2012 17:27:51 +0200	[thread overview]
Message-ID: <4FE48EF7.6060101@canonical.com> (raw)
In-Reply-To: <s5hsjdnbjka.wl%tiwai@suse.de>

On 06/22/2012 02:46 PM, Takashi Iwai wrote:
>   /*
> + * Inverted digital-mic handling
> + *
> + * First off, it's a bit tricky.  The "Inverted Internal Mic Capture Switch"
> + * gives the additional mute only to the right channel of the digital mic
> + * capture stream.  This is a workaround for avoiding the almost silence
> + * by summing the stereo stereo stream from some (known to be ForteMedia)

Stereo stereo? It's "stereo" in stereo! :-)

> + * digital mic unit.
> + *
> + * The logic is to call alc_inv_dmic_sync() after each action (possibly)
> + * modifying ADC amp.  When the mute flag is set, it mutes the R-channel
> + * without caching so that the cache can still keep the original value.
> + * The cached value is then restored when the flag is set off or any other
> + * than d-mic is used as the current input source.

Ok, I get it now.

There is a slight drawback with this (IMO a bit hacky) patch, and that 
is that you can get a short signal spike on the right channel when you 
turn "Capture Switch" on while "Inverted Capture" is off. Hopefully it 
is not a practical problem.

Thanks for looking at this long-standing problem :-)

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic

  reply	other threads:[~2012-06-22 15:27 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28  8:57 [RFC PATCH] Inverted internal mic David Henningsson
2012-02-28  9:24 ` Takashi Iwai
2012-02-28  9:54   ` David Henningsson
2012-02-28 10:38     ` Takashi Iwai
2012-02-28 13:07       ` David Henningsson
2012-02-28 13:22         ` Takashi Iwai
2012-02-28 14:19           ` David Henningsson
2012-02-28 15:20             ` Takashi Iwai
2012-02-28 18:11               ` David Henningsson
2012-02-28 19:42                 ` Takashi Iwai
2012-02-29  9:21                   ` David Henningsson
2012-02-29  9:56                     ` Takashi Iwai
2012-02-29 10:45                       ` David Henningsson
2012-02-29 16:36                         ` Takashi Iwai
2012-06-19  3:07             ` Eliot Blennerhassett
2012-06-19  7:43               ` David Henningsson
2012-06-20 13:31                 ` Takashi Iwai
2012-06-21  1:15                   ` David Henningsson
2012-06-21 12:52                     ` Takashi Iwai
2012-06-21 13:04                       ` David Henningsson
2012-06-21 13:19                         ` Takashi Iwai
2012-06-21 14:23                           ` David Henningsson
2012-06-22  9:33                             ` Takashi Iwai
2012-06-22 10:46                               ` David Henningsson
2012-06-22 11:00                                 ` Takashi Iwai
2012-06-22 12:46                                   ` Takashi Iwai
2012-06-22 15:27                                     ` David Henningsson [this message]
2012-06-22 15:37                                       ` Takashi Iwai
2012-06-22 17:33                                         ` David Henningsson
2012-06-23  2:58                                           ` Eliot Blennerhassett
2012-06-23  8:40                                             ` Takashi Iwai
2012-06-23  8:39                                           ` Takashi Iwai
2012-06-25  8:04                                             ` David Henningsson
2012-06-25  8:18                                               ` Takashi Iwai
2012-06-20  8:02               ` Takashi Iwai
2012-06-20 10:54                 ` Eliot Blennerhassett
2012-02-29 11:02 ` Raymond Yau
2012-06-20 21:53 ` James Courtier-Dutton
2012-06-21  5:56   ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2014-10-20 13:52 rodney byne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE48EF7.6060101@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=eliot@blennerhassett.gen.nz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox