From: Rajeev kumar <rajeev-dlh.kumar@st.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH V4 1/2] ASoC: STA529: Add support for STA529 Audio Codec
Date: Wed, 4 Jul 2012 10:30:24 +0530 [thread overview]
Message-ID: <4FF3CDE8.3020206@st.com> (raw)
In-Reply-To: <20120703190300.GA29030@opensource.wolfsonmicro.com>
Hello Mark,
On 7/4/2012 12:33 AM, Mark Brown wrote:
> On Tue, Jul 03, 2012 at 05:24:58PM +0530, Rajeev Kumar wrote:
>
>> +
>> + /* set FFX audio frequency range */
>> + val = (((val& 0x83) | (play_freq_val<< 4)) | (record_freq_val<< 2));
>> + snd_soc_update_bits(codec, STA529_MISC, FREQ_RANGE_MSK, val);
>
> This is more buggy than last time, it's still setting both playback and
> record configuration but instead of using update_bits() like write()
> it's now using val uninitialised. As I said last time it looks like you
> want to move this into the playback/capture if statement immediately above.
next prev parent reply other threads:[~2012-07-04 5:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 11:54 [PATCH V4 0/2] Add support for sta529 audio codec and spdif_out controller Rajeev Kumar
2012-07-03 11:54 ` [PATCH V4 1/2] ASoC: STA529: Add support for STA529 Audio Codec Rajeev Kumar
2012-07-03 19:03 ` Mark Brown
2012-07-04 5:00 ` Rajeev kumar [this message]
2012-07-04 5:06 ` Rajeev kumar
2012-07-03 11:54 ` [PATCH V4 2/2] ASoC: SPEAr spdif_out: Add spdif out support Rajeev Kumar
2012-07-03 18:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3CDE8.3020206@st.com \
--to=rajeev-dlh.kumar@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox