From: Rajeev kumar <rajeev-dlh.kumar@st.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>, Liam Girdwood <lrg@ti.com>
Subject: Re: [patch] ASoC: STA529: fix an error message
Date: Wed, 11 Jul 2012 12:21:01 +0530 [thread overview]
Message-ID: <4FFD2255.1040102@st.com> (raw)
In-Reply-To: <20120711064123.GI11812@elgon.mountain>
Hello Dan,
On 7/11/2012 12:11 PM, Dan Carpenter wrote:
> GCC complains that "ret" is uninitialized here.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
> diff --git a/sound/soc/codecs/sta529.c b/sound/soc/codecs/sta529.c
> index a9f34c7..0c225cd 100644
> --- a/sound/soc/codecs/sta529.c
> +++ b/sound/soc/codecs/sta529.c
> @@ -397,8 +397,9 @@ static __devinit int sta529_i2c_probe(struct i2c_client *i2c,
>
> sta529->regmap = devm_regmap_init_i2c(i2c,&sta529_regmap);
> if (IS_ERR(sta529->regmap)) {
> + ret = PTR_ERR(sta529->regmap);
> dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret);
> - return PTR_ERR(sta529->regmap);
> + return ret;
> }
>
> i2c_set_clientdata(i2c, sta529);
> .
>
Thanks for the patch.
Acked-By: Rajeev Kumar <rajeev-dlh.kumar@st.com>
~Rajeev
next prev parent reply other threads:[~2012-07-11 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 6:41 [patch] ASoC: STA529: fix an error message Dan Carpenter
2012-07-11 6:51 ` Rajeev kumar [this message]
2012-07-11 9:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD2255.1040102@st.com \
--to=rajeev-dlh.kumar@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox