From: mengdong.lin@linux.intel.com
To: alsa-devel@alsa-project.org, broonie@kernel.org
Cc: Mengdong Lin <mengdong.lin@linux.intel.com>,
tiwai@suse.de, hardik.t.shah@intel.com,
guneshwor.o.singh@intel.com, liam.r.girdwood@linux.intel.com,
vinod.koul@intel.com, rakesh.a.ughreja@intel.com,
mengdong.lin@intel.com
Subject: [PATCH v7 04/11] ASoC: topology: ABI - Add flags and private data to PCM
Date: Thu, 3 Nov 2016 01:03:34 +0800 [thread overview]
Message-ID: <4b17e13ac1c24a6dab791c8fd9abf79f410e7d6e.1478071138.git.mengdong.lin@linux.intel.com> (raw)
In-Reply-To: <cover.1478071138.git.mengdong.lin@linux.intel.com>
From: Mengdong Lin <mengdong.lin@linux.intel.com>
This is the remaining update to PCM ABI object of version 5.
The flags will be applied to FE (Front End) links and can also be used
by physical links. The private data is reserved for future extension, so
offset update will add the private data size.
Now user space is using ABI v4, and the previous patch "ASoC: topology:
make PCM backward compatible from ABI v4" can assure the backward
compatibility.
Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com>
diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h
index 69cae71..aeb4082 100644
--- a/include/uapi/sound/asoc.h
+++ b/include/uapi/sound/asoc.h
@@ -146,6 +146,11 @@
#define SND_SOC_DAI_FORMAT_MSB SND_SOC_DAI_FORMAT_LEFT_J
#define SND_SOC_DAI_FORMAT_LSB SND_SOC_DAI_FORMAT_RIGHT_J
+/* DAI link flags */
+#define SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_RATES (1 << 0)
+#define SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_CHANNELS (1 << 1)
+#define SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_SAMPLEBITS (1 << 2)
+
/*
* Block Header.
* This header precedes all object and object arrays below.
@@ -456,6 +461,9 @@ struct snd_soc_tplg_pcm {
struct snd_soc_tplg_stream stream[SND_SOC_TPLG_STREAM_CONFIG_MAX]; /* for DAI link */
__le32 num_streams; /* number of streams */
struct snd_soc_tplg_stream_caps caps[2]; /* playback and capture for DAI */
+ __le32 flag_mask; /* bitmask of flags to configure */
+ __le32 flags; /* SND_SOC_TPLG_LNK_FLGBIT_* flag value */
+ struct snd_soc_tplg_private priv;
} __attribute__((packed));
diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
index 2f9b64e..8baa176 100644
--- a/sound/soc/soc-topology.c
+++ b/sound/soc/soc-topology.c
@@ -1676,6 +1676,24 @@ static int soc_tplg_dai_create(struct soc_tplg *tplg,
return snd_soc_register_dai(tplg->comp, dai_drv);
}
+static void set_link_flags(struct snd_soc_dai_link *link,
+ unsigned int flag_mask, unsigned int flags)
+{
+ if (flag_mask & SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_RATES)
+ link->symmetric_rates =
+ flags & SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_RATES ? 1 : 0;
+
+ if (flag_mask & SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_CHANNELS)
+ link->symmetric_channels =
+ flags & SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_CHANNELS ?
+ 1 : 0;
+
+ if (flag_mask & SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_SAMPLEBITS)
+ link->symmetric_samplebits =
+ flags & SND_SOC_TPLG_LNK_FLGBIT_SYMMETRIC_SAMPLEBITS ?
+ 1 : 0;
+}
+
/* create the FE DAI link */
static int soc_tplg_link_create(struct soc_tplg *tplg,
struct snd_soc_tplg_pcm *pcm)
@@ -1703,6 +1721,8 @@ static int soc_tplg_link_create(struct soc_tplg *tplg,
link->dynamic = 1;
link->dpcm_playback = pcm->playback;
link->dpcm_capture = pcm->capture;
+ if (pcm->flag_mask)
+ set_link_flags(link, pcm->flag_mask, pcm->flags);
/* pass control to component driver for optional further init */
ret = soc_tplg_dai_link_load(tplg, link);
@@ -1848,10 +1868,14 @@ static int soc_tplg_pcm_elems_load(struct soc_tplg *tplg,
/* create the FE DAIs and DAI links */
soc_tplg_pcm_create(tplg, _pcm);
+
+ /* offset by version-specific struct size and
+ * real priv data size
+ */
+ tplg->pos += pcm->size + _pcm->priv.size;
+
if (!abi_match)
kfree(_pcm); /* free the duplicated one */
-
- tplg->pos += pcm->size; /* offset by version-specific size */
}
dev_dbg(tplg->dev, "ASoC: adding %d PCM DAIs\n", count);
--
2.7.4
next prev parent reply other threads:[~2016-11-02 17:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 16:59 [PATCH v7 00/11] ASoC: topology: Remaining kernel patches mengdong.lin
2016-11-02 17:00 ` [PATCH v7 01/11] ASoC: topology: Make PCM backward compatible from ABI v4 mengdong.lin
2016-11-03 16:12 ` Mark Brown
2016-11-03 16:23 ` Applied "ASoC: topology: Make PCM backward compatible from ABI v4" to the asoc tree Mark Brown
2016-11-02 17:02 ` [PATCH v7 02/11] ASoC: topology: Only use valid names of PCM for the kernel DAI & DAI link mengdong.lin
2016-11-03 16:55 ` Applied "ASoC: topology: Only use valid names of PCM for the kernel DAI & DAI link" to the asoc tree Mark Brown
2016-11-02 17:03 ` [PATCH v7 03/11] ASoC: topology: Support topology file of ABI v4 mengdong.lin
2016-11-02 17:03 ` mengdong.lin [this message]
2016-11-03 16:55 ` Applied "ASoC: topology: ABI - Add flags and private data to PCM" to the asoc tree Mark Brown
2016-11-02 17:03 ` [PATCH v7 05/11] ASoC: topology: ABI - Update physical DAI link configuration for version 5 mengdong.lin
2016-11-02 17:04 ` [PATCH v7 06/11] ASoC: Define API to find a dai link mengdong.lin
2016-11-02 17:04 ` [PATCH v7 07/11] ASoC: topology: Add support to configure existing physical DAI links mengdong.lin
2016-11-04 17:22 ` Mark Brown
2016-11-05 13:35 ` Lin, Mengdong
2016-11-02 17:04 ` [PATCH v7 08/11] ASoC: topology: Rename the function to create a FE link mengdong.lin
2016-11-02 17:05 ` [PATCH v7 09/11] ASoC: topology: ABI - Rename struct and type for physical DAIs mengdong.lin
2016-11-02 17:05 ` [PATCH v7 10/11] ASoC: topology: Rename functions & variables " mengdong.lin
2016-11-02 17:05 ` [PATCH v7 11/11] ASoC: topology: ABI - Add voice wake up flag for DAI links mengdong.lin
2016-11-04 17:36 ` Mark Brown
2016-11-05 13:35 ` Lin, Mengdong
2016-11-04 17:38 ` Applied "ASoC: topology: ABI - Add voice wake up flag for DAI links" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b17e13ac1c24a6dab791c8fd9abf79f410e7d6e.1478071138.git.mengdong.lin@linux.intel.com \
--to=mengdong.lin@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guneshwor.o.singh@intel.com \
--cc=hardik.t.shah@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).