From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Brent Lu <brent.lu@intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Jaroslav Kysela <perex@perex.cz>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 13/20] ASoC: Intel: replace dpcm_playback/capture to playback/capture_only
Date: Thu, 18 May 2023 12:39:14 +0200 [thread overview]
Message-ID: <4d3dd0a9-b7ae-ea5e-a4a8-766e425c49c0@linux.intel.com> (raw)
In-Reply-To: <87jzx6p4u4.wl-kuninori.morimoto.gx@renesas.com>
On 5/18/2023 7:48 AM, Kuninori Morimoto wrote:
> soc_get_playback_capture() is now handling DPCM and normal comprehensively
> for playback/capture stream. We can use playback/capture_only flag
> instead of using dpcm_playback/capture. This patch replace these.
>
> NOTE
> Some Intel code was complex. Please check this patch deeply.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> sound/soc/intel/avs/boards/da7219.c | 2 -
> sound/soc/intel/avs/boards/dmic.c | 4 +-
> sound/soc/intel/avs/boards/hdaudio.c | 4 --
> sound/soc/intel/avs/boards/i2s_test.c | 2 -
> sound/soc/intel/avs/boards/max98357a.c | 2 +-
> sound/soc/intel/avs/boards/max98373.c | 2 -
> sound/soc/intel/avs/boards/max98927.c | 2 -
> sound/soc/intel/avs/boards/nau8825.c | 2 -
> sound/soc/intel/avs/boards/rt274.c | 2 -
> sound/soc/intel/avs/boards/rt286.c | 2 -
> sound/soc/intel/avs/boards/rt298.c | 2 -
> sound/soc/intel/avs/boards/rt5682.c | 2 -
> sound/soc/intel/avs/boards/ssm4567.c | 2 -
> sound/soc/intel/boards/bdw-rt5650.c | 4 --
> sound/soc/intel/boards/bdw-rt5677.c | 4 --
> sound/soc/intel/boards/bdw_rt286.c | 10 ++--
> sound/soc/intel/boards/bxt_da7219_max98357a.c | 32 ++++++-----
> sound/soc/intel/boards/bxt_rt298.c | 26 +++++----
> sound/soc/intel/boards/bytcht_cx2072x.c | 6 +--
> sound/soc/intel/boards/bytcht_da7213.c | 6 +--
> sound/soc/intel/boards/bytcht_es8316.c | 6 +--
> sound/soc/intel/boards/bytcht_nocodec.c | 6 +--
> sound/soc/intel/boards/bytcr_rt5640.c | 6 +--
> sound/soc/intel/boards/bytcr_rt5651.c | 6 +--
> sound/soc/intel/boards/bytcr_wm5102.c | 6 +--
> sound/soc/intel/boards/cht_bsw_max98090_ti.c | 6 +--
> sound/soc/intel/boards/cht_bsw_nau8824.c | 6 +--
> sound/soc/intel/boards/cht_bsw_rt5645.c | 6 +--
> sound/soc/intel/boards/cht_bsw_rt5672.c | 6 +--
> sound/soc/intel/boards/cml_rt1011_rt5682.c | 14 ++---
> sound/soc/intel/boards/ehl_rt5660.c | 14 +++--
> sound/soc/intel/boards/glk_rt5682_max98357a.c | 30 +++++------
> sound/soc/intel/boards/hsw_rt5640.c | 10 ++--
> sound/soc/intel/boards/kbl_da7219_max98357a.c | 26 +++++----
> sound/soc/intel/boards/kbl_da7219_max98927.c | 54 +++++++++----------
> sound/soc/intel/boards/kbl_rt5660.c | 18 +++----
> sound/soc/intel/boards/kbl_rt5663_max98927.c | 44 +++++++--------
> .../intel/boards/kbl_rt5663_rt5514_max98927.c | 22 ++++----
> sound/soc/intel/boards/skl_hda_dsp_common.c | 14 ++---
> .../soc/intel/boards/skl_nau88l25_max98357a.c | 26 +++++----
> sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 26 ++++-----
> sound/soc/intel/boards/skl_rt286.c | 26 +++++----
> sound/soc/intel/boards/sof_cs42l42.c | 12 +----
> sound/soc/intel/boards/sof_da7219_max98373.c | 16 +++---
> sound/soc/intel/boards/sof_es8336.c | 8 ++-
> sound/soc/intel/boards/sof_nau8825.c | 12 +----
> sound/soc/intel/boards/sof_pcm512x.c | 8 +--
> sound/soc/intel/boards/sof_rt5682.c | 12 +----
> sound/soc/intel/boards/sof_sdw.c | 4 +-
> sound/soc/intel/boards/sof_ssp_amp.c | 11 ++--
> sound/soc/intel/boards/sof_wm8804.c | 2 -
> 51 files changed, 209 insertions(+), 372 deletions(-)
>
I've looked twice at avs part and skimmed through rest of boards,
overall seems good, but please split sound/soc/intel/avs/boards/ and
sound/soc/intel/boards/ into two separate patches.
next prev parent reply other threads:[~2023-05-18 10:41 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 5:46 [PATCH 00/20] ASoC: replace dpcm_playback/capture to playback/capture_only Kuninori Morimoto
2023-05-18 5:46 ` [PATCH 01/20] ASoC: soc-pcm.c: indicate error if stream has no playback no capture Kuninori Morimoto
2023-05-18 10:37 ` Amadeusz Sławiński
2023-05-18 5:46 ` [PATCH 02/20] ASoC: soc-pcm.c: use dai_link on soc_get_playback_capture() Kuninori Morimoto
2023-05-18 10:37 ` Amadeusz Sławiński
2023-05-18 5:46 ` [PATCH 03/20] ASoC: soc-pcm.c: cleanup soc_get_playback_capture() error Kuninori Morimoto
2023-05-18 10:38 ` Amadeusz Sławiński
2023-05-18 5:47 ` [PATCH 04/20] ASoC: soc-pcm.c: use temporary variable at soc_get_playback_capture() Kuninori Morimoto
2023-05-18 10:38 ` Amadeusz Sławiński
2023-05-18 23:12 ` Kuninori Morimoto
2023-05-18 5:47 ` [PATCH 05/20] ASoC: soc-pcm.c: tidyup playback/capture_only " Kuninori Morimoto
2023-05-18 10:38 ` Amadeusz Sławiński
2023-05-18 5:47 ` [PATCH 06/20] ASoC: soc-pcm.c: cleanup normal connection loop at soc_get_playback_capture() part1 Kuninori Morimoto
2023-05-18 10:38 ` Amadeusz Sławiński
2023-05-18 5:47 ` [PATCH 07/20] ASoC: soc-pcm.c: cleanup normal connection loop at soc_get_playback_capture() part2 Kuninori Morimoto
2023-05-18 10:38 ` Amadeusz Sławiński
2023-05-18 5:47 ` [PATCH 08/20] ASoC: soc-pcm.c: cleanup soc_get_playback_capture() Kuninori Morimoto
2023-05-18 10:38 ` Amadeusz Sławiński
2023-05-19 9:57 ` Amadeusz Sławiński
2023-05-22 4:35 ` Kuninori Morimoto
2023-05-22 9:14 ` Amadeusz Sławiński
2023-05-22 23:49 ` Kuninori Morimoto
2023-05-24 11:21 ` Amadeusz Sławiński
2023-05-24 23:48 ` Kuninori Morimoto
2023-05-18 5:47 ` [PATCH 09/20] ASoC: amd: replace dpcm_playback/capture to playback/capture_only Kuninori Morimoto
2023-05-18 5:48 ` [PATCH 10/20] ASoC: fsl: " Kuninori Morimoto
2023-05-18 5:48 ` [PATCH 11/20] ASoC: sof: " Kuninori Morimoto
2023-05-18 5:48 ` [PATCH 12/20] ASoC: meson: " Kuninori Morimoto
2023-05-18 5:48 ` [PATCH 13/20] ASoC: Intel: " Kuninori Morimoto
2023-05-18 10:39 ` Amadeusz Sławiński [this message]
2023-05-18 23:15 ` Kuninori Morimoto
2023-05-18 5:49 ` [PATCH 14/20] ASoC: samsung: " Kuninori Morimoto
2023-05-18 5:49 ` [PATCH 15/20] ASoC: mediatek: " Kuninori Morimoto
2023-05-18 5:49 ` [PATCH 16/20] ASoC: soc-dai.c: " Kuninori Morimoto
2023-05-18 10:39 ` Amadeusz Sławiński
2023-05-18 23:18 ` Kuninori Morimoto
2023-05-18 5:49 ` [PATCH 17/20] ASoC: soc-core.c: " Kuninori Morimoto
2023-05-18 10:39 ` Amadeusz Sławiński
2023-05-18 5:49 ` [PATCH 18/20] ASoC: soc-topology.c: " Kuninori Morimoto
2023-05-18 10:40 ` Amadeusz Sławiński
2023-05-18 5:49 ` [PATCH 19/20] ASoC: soc-compress.c: " Kuninori Morimoto
2023-05-18 10:40 ` Amadeusz Sławiński
2023-05-18 5:49 ` [PATCH 20/20] ASoC: soc-pcm.c: remove dpcm_playback/capture Kuninori Morimoto
2023-05-18 10:40 ` Amadeusz Sławiński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d3dd0a9-b7ae-ea5e-a4a8-766e425c49c0@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox