From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A722EC4CECC for ; Mon, 27 Apr 2020 20:01:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35824206D9 for ; Mon, 27 Apr 2020 20:01:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="CqsVxXx+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35824206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7F035167F; Mon, 27 Apr 2020 22:00:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7F035167F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588017709; bh=WxvgNkyLcQn42Pz48pbBkt5kATll5Ch0dv6g9EN+Wl8=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CqsVxXx+uNG4Rv782b//94+gas/fEPOLTMUywAZtjH7cC8HiewmCmwcz23LjFvaMT O6Kq42+HTr/MtCgNmj/u9JSGmjT1qf5OLjwjdgBfgLR0etJwxhTvrxR+a4pb1+Iwpp fw/zsBZfWd84VA/Bia1yw8w4X6rRdRMabgNZPU60= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F0DC7F80217; Mon, 27 Apr 2020 22:00:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 40C3DF8022B; Mon, 27 Apr 2020 22:00:57 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AD7CDF80113 for ; Mon, 27 Apr 2020 22:00:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AD7CDF80113 IronPort-SDR: WKHMmsELl/MloiA4uBhdUPBlAIqwjl+l2Ize3wpNJVm+LkF09Qv1R43t4aKHic9DJibBHZ/dMN CZ79vjDDUCrg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 13:00:44 -0700 IronPort-SDR: fDtLeEuP3sSVa4mdzkBv3R8A6qi93TSOKes1DtKZNN8Vm0Vc+BkZ8YybBpysPl6vVv0r90cxIR dKNt5Ylspu/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,325,1583222400"; d="scan'208";a="281888165" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.213.7.127]) ([10.213.7.127]) by fmsmga004.fm.intel.com with ESMTP; 27 Apr 2020 13:00:41 -0700 Subject: Re: [PATCH v2 0/3] add channel constraint for BDW machine drivers To: Brent Lu , alsa-devel@alsa-project.org References: <1588007614-25061-1-git-send-email-brent.lu@intel.com> From: Cezary Rojewski Message-ID: <4d4b8978-88b3-9d54-8812-85fe35456ead@intel.com> Date: Mon, 27 Apr 2020 22:00:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1588007614-25061-1-git-send-email-brent.lu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Guennadi Liakhovetski , Kuninori Morimoto , linux-kernel@vger.kernel.org, Jie Yang , Takashi Iwai , Pierre-Louis Bossart , Liam Girdwood , Ben Zhang , Mac Chiang , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2020-04-27 19:13, Brent Lu wrote: > The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel > recording while other two drivers support only 2-channel recording. HW > constraints are implemented to reflect the hardware limitation on BDW > platform. > > Changes since v1: > - Change the patch title. > - Remove the DUAL_CHANNEL and QUAD_CHANNEL macros which are too obvious. > - Follow the naming convertion, using 'bdw_rt5650_' and 'bdw_rt5677_' to > name startup functions. > - Refine the comments in startup functions. > - Redesign the bdw_rt5650_fe_startup() function for readability. > - Add an assignment to initialize runtime->hw.channels_max variable. > Thank you for addressing all listed issues. I'll recheck hw constraints on my end just to be sure but this series looks good already, so: Acked-by: Cezary Rojewski