From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonyoung Shim <dofmind@gmail.com>
Subject: Re: [PATCH] ASoC: Fix long name of control for
	dapm_switch
Date: Fri, 6 Mar 2009 09:28:06 +0900
Message-ID: <4e1455be0903051628ifb0fe70w32d9babf13c7a43d@mail.gmail.com>
References: <4e1455be0903031747s65097766saea220037d1335ff@mail.gmail.com>
	<20090305172624.GH2416@sirena.org.uk>
	<4e1455be0903051602r198fd9a2gc5bde0ffd9ac8c0d@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.168])
	by alsa0.perex.cz (Postfix) with ESMTP id 8CFB2103896
	for <alsa-devel@alsa-project.org>; Fri,  6 Mar 2009 01:28:07 +0100 (CET)
Received: by wf-out-1314.google.com with SMTP id 26so209625wfd.23
	for <alsa-devel@alsa-project.org>; Thu, 05 Mar 2009 16:28:06 -0800 (PST)
In-Reply-To: <4e1455be0903051602r198fd9a2gc5bde0ffd9ac8c0d@mail.gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

> ok, i will resend the patch.
>
>>
>>>
>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 switch (w->id) {
>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 case snd_soc_dapm_mixer:
>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 default:
>>
>> Your chanegs here appear to only flip to an if/else from a switch
>> statement? =A0Please mention things like this in your commit logs (or
>> split them into separate patches) - it makes your changes easier to
>> review.
>
> I think that a switch statement is used unnecessarily because this part h=
as
> only to check whether w->id is named_ctl.
> ok, i will send them into splited patches.
> Thanks.

I found your commit at for-2.6.30 branch of your repository.
Thanks for your fixes.

-- =

- Joonyoung Shim