From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH] ASoC: topology: Increase
 SND_SOC_TPLG_NUM_TEXTS to 32
Date: Fri, 20 Jul 2018 11:02:12 -0500
Message-ID: <4f269916-9c74-a2d1-3cde-8fc67e1ae161@linux.intel.com>
References: <1532082427-4912-1-git-send-email-puneethx.prabhu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by alsa0.perex.cz (Postfix) with ESMTP id 3EEDF267749
 for <alsa-devel@alsa-project.org>; Fri, 20 Jul 2018 18:02:17 +0200 (CEST)
In-Reply-To: <1532082427-4912-1-git-send-email-puneethx.prabhu@intel.com>
Content-Language: en-US
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Puneeth Prabhu <puneethx.prabhu@intel.com>, ALSA ML <alsa-devel@alsa-project.org>, Mark Brown <broonie@kernel.org>
Cc: cezary.rojewski@intel.com, Takashi Iwai <tiwai@suse.de>, pardha.saradhi.kesapragada@intel.com, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Patches Audio <patches.audio@intel.com>, gustaw.lewandowski@intel.com
List-Id: alsa-devel@alsa-project.org

On 7/20/18 5:27 AM, Puneeth Prabhu wrote:
> Topology supports maximum of 32 configs for a path
> whereas kernel can support only 16 configs of a path.
> So, increase SND_SOC_TPLG_NUM_TEXTS to 32 to support 32
> configs for a path.

What do you mean by "Topology supports maximum of 32 configs for a 
path"? I checked in alsa-lib and the same value of 16 is used.
I don't get how a change at the kernel level is going to help if the 
information generated by alsatplg uses a different structure.

I also don't get how you enable this change, the code in skl-topology 
only accesses the .priv structure in the enum, but if you change the 
size of the texts array then all your pointers are incorrect so you'd 
handle garbage data.

> 
> Signed-off-by: Puneeth Prabhu <puneethx.prabhu@intel.com>
> Signed-off-by: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
> ---
>   include/uapi/sound/asoc.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h
> index a74ca23..5b1411b 100644
> --- a/include/uapi/sound/asoc.h
> +++ b/include/uapi/sound/asoc.h
> @@ -88,7 +88,7 @@
>   #define SND_SOC_TPLG_MAGIC		0x41536F43 /* ASoC */
>   
>   /* string sizes */
> -#define SND_SOC_TPLG_NUM_TEXTS		16
> +#define SND_SOC_TPLG_NUM_TEXTS		32
>   
>   /* ABI version */
>   #define SND_SOC_TPLG_ABI_VERSION	0x5	/* current version */
>